On Wed, Feb 19, 2025 at 07:15:51PM +0100, Volker Schlecht wrote:
> deno 2.2.0 wants the session extension (https://sqlite.org/sessionintro.html)
> enabled in sqlite3. Probably there's a way to disable that in deno if need be,
> but the extension seems innocent enough to enable it in the sqlite3 port.
> 
> Opinions? Builds and works on arm64 and amd64...

Something's very wrong here. After 90 minutes of build I got this list
of failures and stopped the build:

databases/libzdb mail/bogofilter,sqlite3 databases/sqlbox net/ircd-ratbox www/kcaldav sysutils/fdupes mail/postfix/stable telephony/siproxd lang/jimtcl mail/opensmtpd-tables/sqlite mail/postfix/stable35 www/smarc net/litterbox

Picking a few random ones:

databases/libzdb:

checking for SQLite3... yes
checking for library containing sqlite3_open... no
checking for oracle... checking if Oracle support is enabled... no
configure: error: No available database found or selected. Try configure --help

databases/sqlbox:

cc -shared -o libsqlbox.so.1 alloc.o  close.o  exec.o  finalise.o  hier.o  io.o  lastid.o  main.o  open.o  parm.o  ping.o  prepare_bind.o  rebind.o  role.o  sqlite3.o  step.o  transaction.o  warn.o compats.o  -lm  -L/usr/local/lib -lsqlite3  -Wl,-soname,libsqlbox.so.1
ld: error: relocation R_X86_64_PC32 cannot be used against symbol 'sqlite3_free'; recompile with -fPIC
>>> defined in /usr/local/lib/libsqlite3.a(sqlite3.o)
>>> referenced by sqlite3.c:0
>>>               sqlite3.o:(sqlite3_step) in archive /usr/local/lib/libsqlite3.a


www/smarc:

cc -c server.c -o server.o -DSYSCONFDIR="\"/etc\""
-DMSEARCHD_USER="\"www\"" -O2 -pipe  -MMD -Wall -Wuninitialized -Wunused
-Wmissing-prototypes -Wstrict-prototypes -Wno-pointer-sign
server.c:16:10: fatal error: 'sqlite3.h' file not found
#include <sqlite3.h>
         ^~~~~~~~~~~

mail/postfix/stable

cc -I. -I../../include -I. -I../../include -DDEF_CONFIG_DIR=\"/etc/postfix\" -DDEF_DATA_DIR=\"/var/postfix\" -DHAS_SQLITE -DUSE_TLS -DUSE_SASL_AUTH -DNO_EAI -I/usr/local/include/eopenssl33 -DDEF_SMTPUTF8_ENABLE=\"no\" -DHAS_DEV_URANDOM -DHAS_PCRE=2 -I/usr/local/include -UUSE_DYNAMIC_LIBS -DDEF_SHLIB_DIR=\"no\" -UUSE_DYNAMIC_MAPS -Wmissing-prototypes -Wformat -Wno-comment -fno-common  -O2 -pipe  -I. -I../../include -DOPENBSD  -o sendmail sendmail.o ../../lib/libglobal.a  ../../lib/libutil.a -lsqlite3 -pthread /usr/local/lib/eopenssl33/libssl.a /usr/local/lib/eopenssl33/libcrypto.a -L/usr/local/lib -Wl,-R/usr/local/lib -lpcre2-8
ld: warning: myrand.c(myrand.o:(myrand) in archive ../../lib/libutil.a): warning: rand() may return deterministic values, is that what you want?
ld: warning: concatenate.c(concatenate.o:(concatenate) in archive ../../lib/libutil.a): warning: strcpy() is almost always misused, please use strlcpy()
ld: warning: concatenate.c(concatenate.o:(concatenate) in archive ../../lib/libutil.a): warning: strcat() is almost always misused, please use strlcat()
ld: error: undefined symbol: ceil
>>> referenced by sqlite3.c:131763
>>>               sqlite3.o:(xCeil) in archive /usr/local/lib/libsqlite3.a

ld: error: undefined symbol: floor
>>> referenced by sqlite3.c:131764
>>>               sqlite3.o:(xFloor) in archive /usr/local/lib/libsqlite3.a

ld: error: undefined symbol: log
>>> referenced by sqlite3.c:131806
>>>               sqlite3.o:(logFunc) in archive /usr/local/lib/libsqlite3.a
>>> referenced by sqlite3.c:131824
>>>               sqlite3.o:(logFunc) in archive /usr/local/lib/libsqlite3.a
>>> referenced by sqlite3.c:131814
>>>               sqlite3.o:(logFunc) in archive /usr/local/lib/libsqlite3.a
>>> referenced 1 more times

and so on.

> Index: Makefile
> ===================================================================
> RCS file: /cvs/ports/databases/sqlite3/Makefile,v
> diff -u -p -r1.134 Makefile
> --- Makefile	30 Jan 2025 08:16:03 -0000	1.134
> +++ Makefile	19 Feb 2025 18:08:05 -0000
> @@ -2,10 +2,10 @@ COMMENT=	embedded SQL implementation
>  
>  DISTNAME =	sqlite-autoconf-3480000
>  PKGNAME=	sqlite3-3.48.0
> -REVISION=	0
> +REVISION=	1
>  
>  # XXX needs bumps every time :-
> -SHARED_LIBS +=  sqlite3                   37.30 # 8.6
> +SHARED_LIBS +=  sqlite3                   38.00 # 8.6
>  # sqlite suggests that users might like to assert() that library and header
>  # versions match, so bumps are needed even if function signatures don't change.
>  # ... at the current time the only one noticed is a < check (in subversion)
> @@ -35,7 +35,9 @@ CONFIGURE_ARGS +=	--enable-fts5
>  CFLAGS+=	-DSQLITE_ENABLE_UNLOCK_NOTIFY \
>  		-DSQLITE_ENABLE_FTS3 \
>  		-DSQLITE_ENABLE_DBSTAT_VTAB \
> -		-DSQLITE_ENABLE_COLUMN_METADATA=1
> +		-DSQLITE_ENABLE_COLUMN_METADATA=1 \
> +		-DSQLITE_ENABLE_SESSION \
> +		-DSQLITE_ENABLE_PREUPDATE_HOOK
>  
>  BUILD_DEPENDS =	converters/sqlite2mdoc
>  post-install: