On Tue, Jan 02, 2024 at 01:32:35PM +0000, Stuart Henderson wrote:
> On 2024/01/02 13:54, Sebastien Marie wrote:
> > Stuart Henderson <stu@spacehopper.org> writes:
> > 
> > > On 2024/01/02 08:50, Landry Breuil wrote:
> > >> Le Mon, Jan 01, 2024 at 05:58:21PM +0100, Sebastien Marie a écrit :
> > >> > Hi,
> > >> > 
> > >> > I would like to commit the following diff to the www/mozilla module.
> > >> > 
> > >> > It switches all ports using www/mozilla to use MODULES+=lang/rust
> > >> > instead of BUILD_DEPENDS+=lang/rust, and adds MODRUST_WANTLIB to
> > >> > WANTLIB.
> > >> > 
> > >> > It makes these ports to use _SYSTEM_VERSION-rust and be bumped
> > >> > automatically when rust (compiler or stdlib) changes, and so get the
> > >> > package updated.
> > >> > 
> > >> > It should affect:
> > >> > - mail/mozilla-thunderbird
> > >> > - www/tor-browser/browser
> > >> > - www/firefox-esr
> > >> > - www/mozilla-firefox
> > >> > - www/seamonkey
> > >> > 
> > >> > Comments or OK ?
> > >> 
> > >> i suppose it needs a bump of REVISION for the consumers, if that changes
> > >> WANTLIB ?
> > >
> > > If I read correctly, it shouldn't make an actual change to the @wantlib
> > > lines in packages (which is sorted and deduplicated), so I believe bumps
> > > are not needed.
> > >
> > 
> > in this particular case, I think that WANTLIB doesn't change (but I am
> > not completely sure for all archs). But even if the WANTLIB changed, the
> > ports is now using MODULES+=lang/rust, and it makes the @version tag to
> > be bumped (_SYSTEM_VERSION-rust = 1 , actually). So REVISION bump
> > wouldn't be necessary.
> 
> I'm afraid _SYSTEM_VERSION doesn't avoid the need to bump REVISIONs when
> dependencies/wantlib have changed - it still trips the PLIST_DB checks.

Confirmed, I run into this in my last bulk.

-- 
Antoine