On Wednesday, January 10, 2024 12:30 CET, Stuart Henderson <stu@spacehopper.org> wrote:

> On 2024/01/09 22:24, Sebastian Reitenbach wrote:
> > Hi,
> > 
> > below and attached an update our _very old_ version of comms/rtl-sdr. 
> > Tested with RTL-SDR BLOG on amd64.
> > Tuned in into FM radio station with rtl_fm, tracked aircrafts with rtl_adsb.
> > rtl_test, rtl_power work as well, the other binaries not really tested.
> 
> using async I guess? I don't see any relevant commits so I wonder what
> fixed that...

yes, some of the tools have a "-S" parameter to force to sync mode, but 
at least rtl_fm and rtl_adsb don't have that, but they work for me.


> 
> > more or less a complete overhaul of the port, while there, take MAINTAINER.
> > 
> > comments/test reports/rants, or even OK?
> > 
> > cheers,
> > Sebastian
> > 
> > Index: Makefile
> > ===================================================================
> > RCS file: /cvs/ports/comms/rtl-sdr/Makefile,v
> > diff -u -r1.10 Makefile
> > --- Makefile	20 Sep 2023 06:52:55 -0000	1.10
> > +++ Makefile	9 Jan 2024 21:21:19 -0000
> > @@ -1,32 +1,24 @@
> >  COMMENT=	software to turn RTL2832U into an SDR
> >  
> > -DISTNAME=	rtl-sdr-0.20130412
> > -REVISION=	3
> > +GH_ACCOUNT =	osmocom
> > +GH_PROJECT =	rtl-sdr
> > +GH_TAGNAME =	v2.0.1
> 
> You introduce a mixture of "VAR=" and "VAR =", please stick to one or
> the other.
> 
> > -SHARED_LIBS=	rtlsdr 0.1
> > +SHARED_LIBS=	rtlsdr 0.2
> 
> Requires a major bump, functions have been removed.
> 
> >  CATEGORIES=	comms
> >  
> > -HOMEPAGE=	http://sdr.osmocom.org/trac/wiki/rtl-sdr
> > +MAINTAINER =	Sebastian Reitenbach <sebastia@openbsd.org>
> > +HOMEPAGE=	https://osmocom.org/projects/rtl-sdr/wiki
> >  
> >  # GPLv2+
> >  PERMIT_PACKAGE=	Yes
> >  
> >  WANTLIB += c m pthread usb-1.0
> >  
> > -# http://cgit.osmocom.org/rtl-sdr
> > -SITES=		https://spacehopper.org/mirrors/
> > -
> >  MODULES=	devel/cmake
> >  LIB_DEPENDS=	devel/libusb1
> >  
> > -NO_TEST=	Yes
> > -
> > -# rtl_tcp, rtl_adsb and rtl_fm require asynchronous mode which is
> > -# not currently working. additionally, rtl_adsb and rtl_fm have mutex
> > -# issues (unlocking already-unlocked mutex). other programs have been
> > -# patched to force synchronous mode.   update DESCR if fixing these.
> > -post-install:
> > -	cd ${PREFIX}/bin && rm rtl_adsb rtl_tcp
> > +CONFIGURE_ENV =	CFLAGS=-I${LOCALBASE}/lib LDFLAGS=-L${LOCALBASE}/lib
> 
> The -I isn't needed (and, if it was, setting it in this way is wrong
> because it overrides default compiler flags). Please replace the above
> CONFIGURE_ENV line with
> 
> MODCMAKE_LDFLAGS= -L${LOCALBASE}/lib
> 
> I haven't tested runtime (it will take a while to find my second
> usb-stick and the first is on a linux box in the attic with a very
> hackish antenna that I don't really want to move :) but, with the
> above changes, OK with me.
>