On Thu 11/01/2024 21:19, Jeremie Courreges-Anglas wrote:
> 
> Release notes:
> https://www.samba.org/samba/history/samba-4.19.4.html
> 
> Tests and oks welcome (for -stable too)!

According to checksym; libnetapi, libsamba-credentails and libsmbconf
need a minor bump:

/usr/local/lib/libnetapi.so.3.2 --> /tmp/pobj/samba-4.19.4/fake-amd64/usr/local/lib/libnetapi.so.3.2
Dynamic export changes:
added:
        NetComposeOfflineDomainJoin
        NetComposeOfflineDomainJoin_l
        NetComposeOfflineDomainJoin_r
        ndr_print_NetComposeOfflineDomainJoin

PLT added:
        NetComposeOfflineDomainJoin_l

/usr/local/lib/libsamba-credentials.so.1.3 --> /tmp/pobj/samba-4.19.4/fake-amd64/usr/local/lib/libsamba-credentials.so.1.3
Dynamic export changes:
added:
        cli_credentials_get_domain_and_obtained

/usr/local/lib/libsmbconf.so.14.0 --> /tmp/pobj/samba-4.19.4/fake-amd64/usr/local/lib/libsmbconf.so.14.0
Dynamic export changes:
added:
        samba_copyright_string


Bumps have been added on top of your diff (see below), and build- and
run-tested on amd64 current. Works for me. Build-tested on current. No
issues found.


diff --git Makefile Makefile
index efe0e23a71b..1516135db05 100644
--- Makefile
+++ Makefile
@@ -1,4 +1,4 @@
-VERSION =		4.19.3
+VERSION =		4.19.4
 DISTNAME =		samba-${VERSION}
 EPOCH =			0
 
@@ -19,15 +19,15 @@ SHARED_LIBS =		dcerpc			1.1 \
 			ndr-krb5pac		1.3 \
 			ndr-nbt			2.0 \
 			ndr-standard		5.0 \
-			netapi			3.2 \
-			samba-credentials	1.3 \
+			netapi			3.3 \
+			samba-credentials	1.4 \
 			samba-errors		2.1 \
 			samba-hostconfig	13.0 \
 			samba-passdb		3.0 \
 			samba-util		10.0 \
 			samdb			3.0 \
 			smbclient		6.1 \
-			smbconf			14.0 \
+			smbconf			14.1 \
 			smbldap			1.0 \
 			tevent			2.3 \
 			tevent-util		2.0 \
diff --git distinfo distinfo
index facbecb36ab..e3b081cca2c 100644
--- distinfo
+++ distinfo
@@ -1,2 +1,2 @@
-SHA256 (samba-4.19.3.tar.gz) = KAVTuQ8TGxlAWA3yk2U8npvYkGIB9d725ejBYPC/rJY=
-SIZE (samba-4.19.3.tar.gz) = 41829749
+SHA256 (samba-4.19.4.tar.gz) = QCbZO4ZtsZjIyhaFsPXVJ5P2XG5jyzZBY69mH9/wlow=
+SIZE (samba-4.19.4.tar.gz) = 41839810