On Sat Jan 13, 2024 at 02:15:40AM +0000, Klemens Nanni wrote:
> On Wed, Dec 27, 2023 at 04:55:02PM +0100, Rafael Sadowski wrote:
> > On Wed Dec 27, 2023 at 02:42:20PM +0100, Rafael Sadowski wrote:
> > > Please find attached kpipewire-5.27.10. I have not been able to test it.
> > > I also have no idea how far we are with pipewire. I need it to update
> > > krfb and spectacle. (New dependency since KDE Gear 23.08.x)
> > > 
> > 
> > and here the mentioned kde ports:
> 
> So krfb already uses -DDISABLE_PIPEWIRE=ON and the new version keeps
> building without it.  Looks like the r1.15 VERSION pin could have been
> avoided by doing the r1.21 configure switch right away?
> 
> If you pull FreeBSD's patch to disable it in spectactle as well, there
> is no need for a new KPipeWire port.
> 
> No idea which way is better, just laying out an alternative here.

Thanks for digging so deep. I prefer the KDE build way without patching
it out if there is no impact at run-time.

> 
> Both disabled or enabled after import,
> OK kn
> 
> > @@ -40,12 +38,12 @@ LIB_DEPENDS =	devel/kf5/kauth \
> >  		devel/kf5/kwallet \
> >  		devel/kf5/kwidgetsaddons \
> >  		devel/kf5/kxmlgui \
> > +		devel/kf5/kwayland \
> 
> Not sorted.
> 
> >  		net/libvncserver \
> >  		devel/libinotify \
> > +		x11/kde-plasma/kpipewire \
> >  		x11/qt5/qtx11extras
> >  
> >  CXXFLAGS +=	-I${LOCALBASE}/include
> > -
> > -CONFIGURE_ARGS =	-DDISABLE_PIPEWIRE=ON
> >  
> >  .include <bsd.port.mk>
> 
> [...]
> 
> > @@ -38,14 +33,15 @@ LIB_DEPENDS =	graphics/kimageannotator>=
> >  		devel/kf5/ki18n \
> >  		devel/kf5/kio \
> >  		devel/kf5/kjobwidgets \
> > -		devel/kf5/knewstuff \
> >  		devel/kf5/knotifications \
> >  		devel/kf5/kservice \
> >  		devel/kf5/kwidgetsaddons \
> >  		devel/kf5/kwindowsystem \
> >  		devel/kf5/kxmlgui \
> >  		devel/kf5/purpose \
> > -		devel/kf5/kwayland \
> > +		devel/kf5/kirigami2 \
> > +		x11/qt5/qtquickcontrols2 \
> > +		x11/kde-plasma/kpipewire \
> 
> Not sorted.
> 
> >  		x11/qt5/qtx11extras
> >  
> >  post-install:
>