Index | Thread | Search

From:
Klemens Nanni <kn@openbsd.org>
Subject:
Re: NEW: devel/heatshink devel/libbgcode (cad/prusaslicer dependencies)
To:
Renato Aguiar <renato@renatoaguiar.net>
Cc:
"ports@openbsd.org" <ports@openbsd.org>, Ian Darwin <ian@darwinsys.com>, Johannes Thyssen Tishman <lists@thyssentishman.com>
Date:
Fri, 26 Jan 2024 23:58:47 +0000

Download raw body.

Thread
On Thu, Jan 25, 2024 at 05:19:25PM -0800, Renato Aguiar wrote:
> Hi,
> 
> These 2 ports are dependencies for upcoming cad/prusaslicer update to 2.7.1:
> 
> - devel/heatshrink: data compression/decompression library for
> embedded/real-time systems.

Uses -O3, OPTIMIZE='' in MAKE_FLAGS fixes that.

archivers seems a better category than devel.

DESCR could be a little more descriptive than COMMENT.

Shouldn't the first be a .so file?
	@static-lib lib/libheatshrink_dynamic.a
	@static-lib lib/libheatshrink_static.a

> - devel/libbgcode: Prusa Block & Binary G-code reader / writer /  converter.

Unless consumers require static archives, I recomment
-DBUILD_SHARED_LIBS=ON to get versioned shared libraries, as usual.

DESCR could be a little more descriptive than COMMENT.

port-lib-depends-check says
	Missing: boost_nowide-mt.23 from boost-1.84.0p2v0 (/usr/local/bin/bgcode)
	WANTLIB += boost_nowide-mt

You could annotate the used C++ standard as COMPILER comment.