Hi Stuart,

----- Mail original -----
> The patch fails to apply. Also it patches the install target, which
> is overridden with do-install anyway.
> 
> Patching file Makefile using Plan A...
> Hunk #1 succeeded at 57 with fuzz 2 (offset 11 lines).
> Hunk #2 succeeded at 136 (offset -17 lines).
> Hunk #3 failed at 211.
> Hunk #4 succeeded at 287 with fuzz 1 (offset 27 lines).
> Hunk #5 failed at 327.
> 2 out of 5 hunks failed--saving rejects to Makefile.rej

I don't understand, there is no patch for btop Makefile in my port !?!? Mistake on your side with an old working tree ?
 
> Don't force disable stripping, you're using INSTALL_PROGRAM so it
> will be stripped automatically if appropriate (i.e. stripped normally,
> not stripped if doing a build with DEBUG set).
> 
> You're just using the OS compiler, no need for lang/clang MODULES
> or MODCLANG_VERSION. I'd do this:
> 
> -COMPILER =		base-clang
> -
> -MODULES =		lang/clang
> -MODCLANG_VERSION =	16
> +# C++23
> +COMPILER =	base-clang
>  
> The README should go in share/doc/btop not share/btop.

OK, I modified my port based on your reviews. See my new version in tar.gz attached.

Thanks, Laurent

• btop-1.3.0.tar.gz (1K)