Index | Thread | Search

From:
Thomas Frohwein <tfrohwein@fastmail.com>
Subject:
Re: NEW: games/cromagrally
To:
Omar Polo <op@omarpolo.com>
Cc:
izder456 <izder456@disroot.org>, ports@openbsd.org
Date:
Tue, 30 Jan 2024 15:04:35 -0500

Download raw body.

Thread
On Tue, Jan 30, 2024 at 06:34:52PM +0100, Omar Polo wrote:

[...]

> > I replaced your Makefile alignment with tabs as this is most commonly
> > used in ports in my experience (VARIABLE<space>=<tabs>value).
> 
> ok op@ with NO_TEST removed (it is needed for when `make test' would
> fail due to the absence of a regress suite, in this case it just prints
> 'no tests', so it is fine) and with libsamplerate removed
> 
> 
> Thanks,
> 
> Omar Polo
> 
> --- Makefile.orig	Tue Jan 30 18:25:04 2024
> +++ Makefile	Tue Jan 30 18:25:31 2024
> @@ -24,13 +24,9 @@
>  
>  MODULES =	devel/cmake
>  
> -BUILD_DEPENDS =	audio/libsamplerate
>  LIB_DEPENDS =	devel/sdl2
> -RUN_DEPENDS =	audio/libsamplerate \
> -		devel/desktop-file-utils \
> +RUN_DEPENDS =	devel/desktop-file-utils \
>  		x11/gtk+4,-guic
> -
> -NO_TEST =	Yes
>  
>  CFLAGS +=	-I${X11BASE}/include
>  CXXFLAGS +=	-I${X11BASE}/include
> 

I committed it with those changes, thanks!