Index | Thread | Search

From:
Laurent Cheylus <foxy@free.fr>
Subject:
Re: [new] sysutils/btop v1.3.0
To:
Stuart Henderson <stu@spacehopper.org>
Cc:
Ports <ports@openbsd.org>
Date:
Thu, 8 Feb 2024 10:10:21 +0100

Download raw body.

Thread
Hi,

> Please remove the -O2 from OPTFLAGS, otherwise if you use e.g.
> "make CXXFLAGS=-O0" it uses "-O0 -O2" and the -O2 takes priority.

OK, patch Makefile to remove -O2 flag for compilation.

I also fix install step for btop themes (do-install and regen pkg/PLIST).
 
> I need to use --utf-force otherwise I get this:
> 
> $ btop
> ERROR: No UTF-8 locale detected!
> Use --utf-force argument to force start if you're sure your terminal
> can handle it.
> 
> (I am in a UTF-8 environment but as is common on OpenBSD that's set
> via LC_CTYPE not LC_ALL).

According to the code (https://github.com/aristocratos/btop/blob/main/src/btop.cpp#L915), UTF-8 support is detected via LC_ALL and LANG locales.
I have no issue in my OpenBSD env with UTF-8 support for btop:

$ locale
LANG=en_US.UTF-8
LC_COLLATE="en_US.UTF-8"
LC_CTYPE=en_US.UTF-8
LC_MONETARY="en_US.UTF-8"
LC_NUMERIC="en_US.UTF-8"
LC_TIME="en_US.UTF-8"
LC_MESSAGES="en_US.UTF-8"
LC_ALL=

Laurent