On 2024/02/12 13:42, Jose Maldonado wrote:
> 
> Hello everyone! Another new port here!
> 
> In this case I bring graphics/glad [1] a Multi-Language
> Vulkan/GL/GLES/EGL/GLX/WGL Loader-Generator that is part of the new
> dependencies to build libplacebo (>=v6.338.0) and therefore necessary
> to build mpv (v0.37.0)
> 
> Built and tested, take a look and feedback is welcome.

Some tweaks on top, new tar attached is ok sthen

: -COMMENT =	Multi-Language Vulkan/GL/GLES/EGL/GLX/WGL Loader-Generator
: +COMMENT =	multi-language Vulkan/GL/GLES/EGL/GLX/WGL loader-generator

prefer lowercase in COMMENT except for proper nouns/abbreviations

: -V =		2.0.5
: -PKGNAME =	glad-${V}
: -GH_TAGNAME =	v${V}
: +GH_TAGNAME =	v2.0.5
:  GH_ACCOUNT =	Dav1dde
:  GH_PROJECT =	glad

extra lines not needed, default uses the project name followed b6
tagname with ^v stripped

: -MODULES=		lang/python
: +MODULES =	lang/python

consistent whitespace

: -MODPY_SETUPTOOLS=	Yes
: +MODPY_PYBUILD =	setuptools

use the PEP517 build infrastructure, don't use MODPY_SETUPTOOLS for new ports

: -RUN_DEPENDS =	www/py-jinja2 \
: -		textproc/py-MarkupSafe
: +RUN_DEPENDS =	www/py-jinja2${MODPY_FLAVOR} \
: +		textproc/py-MarkupSafe${MODPY_FLAVOR}

missing flavour extension

:  post-install:
: -	mv -f ${WRKDIST}/example ${PREFIX}/share/examples/glad
: +	${INSTALL_DATA_DIR} ${PREFIX}/share/examples/glad
: +	cp -r ${WRKDIST}/example/* ${PREFIX}/share/examples/glad

it's better not to remove things from the WRKDIST

: -NO_BUILD =		Yes

that's just wrong, there is a build stage

:  Vulkan/GL/GLES/EGL/GLX/WGL Loader-Generator based on the official
:  specifications for multiple languages.
: -
: -Main website: https://glad.dav1d.de/
: -
: -Github: https://github.com/Dav1dde/glad

WWW is added automatically from HOMEPAGE.
Not usually worth adding github links here (it's obvious from the
Makefile anyway).

(+ regen pkg/PLIST)

• glad.tgz (2K)