On 2024/02/20 13:42, Jose Maldonado wrote:
> El Tue, 20 Feb 2024 13:13:02 +0000
> Stuart Henderson <stu@spacehopper.org> escribió:
> > On 2024/02/20 08:52, Jose Maldonado wrote:
> > > El Tue, 20 Feb 2024 11:31:54 +0000
> > > Stuart Henderson <stu@spacehopper.org> escribió:
> > > > I get this:
> > > > 
> > > > $ make port-lib-depends-check
> > > > 
> > > > mpv-0.37.0(multimedia/mpv):
> > > > Extra:  SPIRV-Tools-shared.0 Xinerama.6
> > > > 
> > > > Looks like upstream explicitly stopped using Xinerama so that one
> > > > can be removed.
> > > > 
> > > > What's up with SPIRV-Tools-shared and the new LIB_DEPENDS on
> > > > spirv-tools - I see that the port still uses
> > > > -Dspirv-cross=disabled, I could have missed something but that
> > > > does seem to disable anything to do with spirv?
> > > > 
> > > 
> > > Hi @sthen!
> > > 
> > > In order to be consistent with the changes in x11/vlc, do we also
> > > enable wayland support in multimedia/mpv? I can try this along with
> > > the changes you have indicated
> > 
> > wayland isn't enabled for vlc, it's just the libraries are pulled in
> > via another dependency (gtk+3 in this case, I think) and so need to be
> > listed. (Strangely only listed in libnotify_plugin..?)
> > 
> > I'd prefer to get the update in first without too many more changes,
> > just tie up this remaining issue about the spirv libs, then we can
> > look at whether or not to enable wayland separately afterwards.
> > 
> > $ objdump -p /usr/local/lib/vlc/plugins/notify/libnotify_plugin.so
> > 
> 
> Ok, I understand this. At the rate things are going we will see more
> and more dependencies on Wayland.
> 
> About MPV, I upload a new diff with the corrections. I detail the
> changes:
> 
> 1) Removed Xinerama support (thanks @sthen)
> 
> 2) spirv-cross we don't need it, since from what I see in mpv's
> meson.build, this is a feature aimed at Windows (d3d11).
> 
> 3) Vulkan in mpv can be activated without using spirv-tools (I removed
> it from LIB_DEPENDS and WANTLIB). In this case, libplacebo will take
> care of making the appropriate shader management arrangements (using
> shaderc), as appropriate. I have already tested it by playing video
> with shaders (FSR.glsl) and without these, it works correctly (on
> OpenGL and Vulkan gpu-api-context)and the spirv shaders are processed by
> libplacebo as shown in the log.

Great, thanks. I think this is a good point to commit so I'll do so,
happy to look at wayland as new diffs.