Index | Thread | Search

From:
"Anthony J. Bentley" <bentley@openbsd.org>
Subject:
Re: NEW: emulators/melonds
To:
izder456 <izder456@disroot.org>, Thomas Frohwein <tfrohwein@fastmail.com>, ports@openbsd.org
Date:
Sun, 25 Feb 2024 02:09:20 -0700

Download raw body.

Thread
Anthony J. Bentley writes:
> > I have no opinion whether it's worth fixing or just mark with some
> > NOT_FOR_ARCHS or ONLY_FOR_ARCHS (perhaps ONLY_FOR_ARCHS=${LP64_ARCHS}
> > if it's only really expected to work on 64-bit)
>
> I've reported it upstream:
> https://github.com/melonDS-emu/melonDS/issues/1984
>
> Seems like a simple issue likely to be fixed, IMO BROKEN-i386 would be
> the right choice for now.

Upstream says these files aren't supposed to be built. Does this fix the
build on i386?

Index: Makefile
===================================================================
RCS file: /cvs/ports/emulators/melonds/Makefile,v
diff -u -p -r1.1.1.1 Makefile
--- Makefile	19 Feb 2024 08:19:16 -0000	1.1.1.1
+++ Makefile	25 Feb 2024 09:07:31 -0000
@@ -2,6 +2,7 @@ COMMENT =	Nintendo DS emulator
 
 PKGNAME =	melonds-$V
 V =		0.9.5
+REVISION =	0
 
 DIST_TUPLE +=	github melonDS-emu melonDS $V .
 
Index: patches/patch-src_teakra_src_CMakeLists_txt
===================================================================
RCS file: patches/patch-src_teakra_src_CMakeLists_txt
diff -N patches/patch-src_teakra_src_CMakeLists_txt
--- /dev/null	1 Jan 1970 00:00:00 -0000
+++ patches/patch-src_teakra_src_CMakeLists_txt	25 Feb 2024 09:07:31 -0000
@@ -0,0 +1,22 @@
+Index: src/teakra/src/CMakeLists.txt
+--- src/teakra/src/CMakeLists.txt.orig
++++ src/teakra/src/CMakeLists.txt
+@@ -32,10 +32,15 @@ add_library(teakra
+     register.h
+     shared_memory.h
+     teakra.cpp
+-    test.h
+-    test_generator.cpp
+-    test_generator.h
+ )
++
++if (TEAKRA_BUILD_UNIT_TESTS)
++    target_sources(teakra PUBLIC
++        test.h
++        test_generator.cpp
++        test_generator.h
++    )
++endif()
+ 
+ create_target_directory_groups(teakra)
+