Paco Esteban <paco@e1e0.net> writes:

> After reading other comments, I added the README to ${PREFIX}/share/doc/croc/
> This is markdown, so not so pleasant to read from the terminal.  But
> it's something.

fine with it.

>> > The software has a "relay" mode in which it acts as a daemon.  I did not
>> > include startup scripts or reserve a system user, should we do that ?
>> 
>> I don't have strong opinion about it. I am fine without it, but if you
>> expect users to want to setup a local relay, it might be preferable (as
>> it will be properly configured at first).
>
> I added the startup script and user in the end.  I think it's better to
> have it even if the user base is small.

the @newuser is a bit odd: you have a home defined to
${LOCALSTATEDIR}/croc , but the directory isn't created by the port.

if the relay mode doesn't need an owned directory as home, just use /var/empty

for the rc script, prefer:
  daemon="${TRUEPREFIX}/bin/croc relay"
  daemon_flags=""

so the relay command will not be overrided by user setting.

please note that the default configuration (if the user enable the
script) makes the relay to listen to *:90{09,10,11,12,13}. It might be
preferable to listen to localhost by default (even if not really an
useful relay).

  daemon_flags="--host localhost"

Thanks.
-- 
Sebastien Marie