Index | Thread | Search

From:
Klemens Nanni <kn@openbsd.org>
Subject:
pkg_info: fold Comment newline
To:
ports@openbsd.org, Marc Espie <marc.espie.openbsd@gmail.com>
Date:
Sat, 2 Mar 2024 17:39:10 +0000

Download raw body.

Thread
As per Makefile.template and portcheck(1) COMMENT is <=60 chars, so it'd
fit on the same Comment: line in pkg_info(1) output -- less scrolling!

It just stands out, imho, compared to Maintainer: and WWW: where there's
no such seemingly superfluous line break.

Thoughts?

 Information for inst:quirks-7.11

-Comment:
-exceptions to pkg_add rules
+Comment: exceptions to pkg_add rules

 Description:
 The quirks package allows unpredicted changes to the package system.
 For instance, package name changes, or stuff incorporated into base.

 pkg_add(1) always installs and updates it automatically.

 Maintainer: Marc Espie <espie@openbsd.org>

Index: OpenBSD/PkgInfo.pm
===================================================================
RCS file: /cvs/src/usr.sbin/pkg_add/OpenBSD/PkgInfo.pm,v
diff -u -p -r1.54 PkgInfo.pm
--- OpenBSD/PkgInfo.pm	25 Nov 2023 11:02:23 -0000	1.54
+++ OpenBSD/PkgInfo.pm	22 Feb 2024 14:16:18 -0000
@@ -384,8 +384,7 @@ sub print_info($self, $state, $pkg, $han
 	} else {
 		if ($state->opt('c')) {
 			$state->header($handle);
-			$state->banner("Comment:");
-			$state->say("#1\n", get_comment($handle->info));
+			$state->say("Comment: #1\n", get_comment($handle->info));
 		}
 		if ($state->opt('R') && -f $handle->info.REQUIRED_BY) {
 			$state->header($handle);