On 2024/03/04 13:00, Klemens Nanni wrote:
> Reminded by mbuhl;  these dictionaries have no dependencies and just
> repackage unmodified upstream files.
> 
> Feedback? OK?

There's no real benefit to PKG_ARCH=*. The last time we made use of
it in official package builds was when I was building arm packages on
Thecus N2100 (copying no-arch from amd64) which took several months to
complete a build. Despite that, it was enough pain to work with that
I stopped it before I stopped building on the machine (extra fun when
a port was marked incorrectly). Plus, it's only usable in this way
on builds where bulk build machines from multiple arches are using
the same tree - i.e. for the official builds this was only the case
for release builds.

> Index: Makefile.inc
> ===================================================================
> RCS file: /cvs/ports/education/freedict/Makefile.inc,v
> diff -u -p -r1.2 Makefile.inc
> --- Makefile.inc	4 Mar 2024 12:46:55 -0000	1.2
> +++ Makefile.inc	4 Mar 2024 12:57:07 -0000
> @@ -1,6 +1,7 @@
>  # see https://freedict.org/freedict-database.json for all dictionaries
>  DISTNAME =	freedict-${DICT}-${V}.dictd
>  PKGNAME ?=	${DISTNAME:.dictd=}
> +REVISION ?=	0

You are setting a trap for future updates here, there are independent
version numbers in V in xxx-yyy/Makefile so if you do want to go ahead
with this I would recommend putting the REVISION markers into the subdir
Makefiles too (I know it's a lot of files, but trivial to automate the
bumps and removals in this case)