On 2024/03/13 13:33, Jose Maldonado wrote:
> 
> Hi list!
> 
> I've seen a new update to fast_float (library required for the new
> libplacebo and mpv) that could affect the 7.5 and -current package
> builds due to a change in the project's Github.

Unimportant for release, it's on the bulk build machines already, and
is on one of the fallback distfiles sites.

> The change has been added through a commit [1] that fixes a typo in the
> version of the project in CmakeList.txt, but from upstream instead of
> creating a new version (6.1.1), they have decided to include the change
> and keep calling the version as 6.1.0, breaking the old distinfo.

That's a nuisance, it would be helpful if projects wouldn't do that.

That's not the only change - float_common.h was modified too, so it will
also need a REVISION bump.

https://github.com/fastfloat/fast_float/commit/55a5b3c8e136a6f55cbb13829f284bdc7150567c
 #include <type_traits>
 #include <system_error>
 #ifdef __has_include
-  #if __has_include(<stdfloat>)
+  #if __has_include(<stdfloat>) && (__cplusplus > 202002L || _MSVC_LANG > 202002L)
     #include <stdfloat>
   #endif
 #endif

> This patch solves the problem and unlocks the port build.

The distfile needs to be renamed via the filename{url}sufx mechanism
if the contents have changed. Builds are done from machines with
varying states of the ports tree (it's common to have the build machine
for one arch on one ports checkout and another on a newer one - except
for the special case of release builds, this is the normal situation).
For the main build machines there's a common distfiles directory shared
over NFS, so it's a problem if one machine fetches a new file to match
what it needs, while another is still building and expecting an old
version.

A diff something like this will work, though if there's a new version
upstream before we're ready to reopen commits we might as well just
change to that instead.

Index: Makefile
===================================================================
RCS file: /cvs/ports/devel/fast-float/Makefile,v
diff -u -p -r1.1.1.1 Makefile
--- Makefile	13 Feb 2024 19:45:52 -0000	1.1.1.1
+++ Makefile	13 Mar 2024 18:00:59 -0000
@@ -2,9 +2,11 @@ COMMENT =	fast and exact implementation 
 
 V =		6.1.0
 PKGNAME =	fast-float-${V}
+REVISION =	0
 GH_TAGNAME =	v${V}
 GH_ACCOUNT =	fastfloat
 GH_PROJECT =	fast_float
+DISTFILES =	fast_float-{v}${V}-0.tar.gz
 
 CATEGORIES =	devel
 
Index: distinfo
===================================================================
RCS file: /cvs/ports/devel/fast-float/distinfo,v
diff -u -p -r1.1.1.1 distinfo
--- distinfo	13 Feb 2024 19:45:52 -0000	1.1.1.1
+++ distinfo	13 Mar 2024 18:00:59 -0000
@@ -1,2 +1,2 @@
-SHA256 (fast_float-6.1.0.tar.gz) = qcjKjKfWjC27E0Q0BE+cZs/Uw4PV6Fw2twTTD2voJQY=
-SIZE (fast_float-6.1.0.tar.gz) = 95974
+SHA256 (fast_float-6.1.0-0.tar.gz) = WmKeHxjwN60AFsQerWMOpHHMy832AjntNGbEkdjnyQg=
+SIZE (fast_float-6.1.0-0.tar.gz) = 96104