> Date: Wed, 27 Mar 2024 18:57:11 +1000
> From: Jonathan Matthew <jonathan@d14n.org>
> 
> We've had kernel support for RK3308 based systems for a while, but it's been
> difficult to install on them.  Recent U-Boot versions include support for
> them, so we can fix that now.
> 
> I've replaced the old hand built Rock Pi S firmware I was previously using
> with one built from this port, and it works much better.
> 
> ok?

I think you need to patch the device trees to set the serial console
speed to 115200.  Which probably means you've tested this with a
patches device tree from somewhere else.  Dothings work with the
device tree built into U-Boot?

Otherwise this looks ok.