On 2024/04/13 11:45, Caspar Schutijser wrote:
> Hi,
> 
> Not sure if this is considered useful but this port is broken
> on aarch64 with a different message than what's currently in
> the BROKEN-aarch64 marker so I propose to update it.

That BROKEN line doesn't show the error message, it's an explanation
of what the problem is, with details of the fork of kr/pty which adds
support. I think it's more useful to keep as-is.

The current version upstream in
https://gitlab.com/gitlab-org/gitlab-runner/-/blob/main/go.mod?ref_type=heads
changed to creack/pty so maybe updating will fix things.


> The build fails at follows:
>     # gitlab.com/gitlab-org/gitlab-runner/vendor/github.com/kr/pty
>     /usr/ports/pobj/gitlab-runner-14.2.0/go/src/gitlab.com/gitlab-org/gitlab-runner/vendor/github.com/kr/pty/pty_openbsd.go:24:10: undefined: ptmget
>     /usr/ports/pobj/gitlab-runner-14.2.0/go/src/gitlab.com/gitlab-org/gitlab-runner/vendor/github.com/kr/pty/pty_openbsd.go:25:34: undefined: ioctl_PTMGET
> 
> I decided to only mention the first one in the updated marker.
> 
> BROKEN-arm has the same message; it's possible it's now broken in the
> "updated" way but I can't test that.
> 
> Comments or OKs?
> 
> Caspar
> 
> 
> Index: Makefile
> ===================================================================
> RCS file: /cvs/ports/sysutils/gitlab-runner/Makefile,v
> retrieving revision 1.6
> diff -u -p -r1.6 Makefile
> --- Makefile	27 Sep 2023 17:16:26 -0000	1.6
> +++ Makefile	12 Apr 2024 16:20:03 -0000
> @@ -1,4 +1,4 @@
> -BROKEN-aarch64 =	old kr/pty doesn't support OpenBSD arm arches; needs creack/pty@v1.1.11
> +BROKEN-aarch64 =	gitlab.com/gitlab-org/gitlab-runner/vendor/github.com/kr/pty/pty_openbsd.go:24:10: undefined: ptmget
>  BROKEN-arm =		old kr/pty doesn't support OpenBSD arm arches; needs creack/pty@v1.1.11
>  
>  COMMENT =		CI/CD job runner for GitLab
>