Index | Thread | Search

From:
Stuart Henderson <stu@spacehopper.org>
Subject:
Re: converters/k2pdfopt: unbreak/update to 2.55
To:
Caspar Schutijser <caspar@schutijser.com>
Cc:
ports@openbsd.org
Date:
Thu, 18 Apr 2024 21:49:29 +0100

Download raw body.

Thread
On 2024/04/18 18:30, Caspar Schutijser wrote:
> On Thu, Apr 18, 2024 at 09:55:20AM -0600, Anthony J. Bentley wrote:
> > Stuart Henderson writes:
> > > Perhaps consider replacing pre-patch with this which I think is a little
> > > clearer:
> > >
> > > FIX_CRLF_FILES = `find . -type f`
> > 
> > Can this be tweaked to limit it to text files, without making it too
> > complicated?
> > 
> > I only see a single binary file in the distfile, but still...
> 
> I see this message now after I already committed the diff. I think
> that makes sense, yes. Limiting it to .txt, .c and .h files (the files
> we're patching) also works.
> 
> Comments or OK?

Makes sense, I just suggested the FIX_CRLF_FILES equivalent of what
was there before but this is neater. OK

> Caspar
> 
> 
> Index: Makefile
> ===================================================================
> RCS file: /cvs/ports/converters/k2pdfopt/Makefile,v
> diff -u -p -r1.13 Makefile
> --- Makefile	18 Apr 2024 16:15:44 -0000	1.13
> +++ Makefile	18 Apr 2024 16:28:35 -0000
> @@ -38,7 +38,7 @@ RUN_DEPENDS +=	print/ghostscript/gnu
>  
>  WRKDIST =	${WRKDIR}/k2pdfopt_v${V}
>  
> -FIX_CRLF_FILES =	`find . -type f`
> +FIX_CRLF_FILES =	`find . -type f \( -name '*.txt' -o -name '*.[ch]' \)`
>  
>  post-install:
>  	${INSTALL_MAN} ${WRKDIR}/debian/k2pdfopt.1 ${PREFIX}/man/man1
>