Index | Thread | Search

From:
Kirill A. Korinsky <kirill@korins.ky>
Subject:
Re: archivers/pixz: new port (1.0.7)
To:
OpenBSD ports <ports@openbsd.org>
Date:
Tue, 23 Apr 2024 23:36:01 +0200

Download raw body.

Thread
Thanks for review,

On Tue, 23 Apr 2024 23:19:47 +0200,
Stuart Henderson wrote:
> 
> Small tweaks, mostly to fix things so the tests run properly (symlink
> gstat -> WRKDIR/bin/stat, and BDEP on cppcheck). The cppcheck still
> fails but due to a detected error rather than because it can't run.
> 
> -----
> Checking ../src/write.c ...
> ../src/write.c:460:24: error: Uninitialized variable: obuf [uninitvar]
>             if (fwrite(obuf, CHUNKSIZE - gStream.avail_out, 1, gOutFile) != 1)
>                        ^
> ../src/write.c:527:24: error: Uninitialized variable: obuf [uninitvar]
>             if (fwrite(obuf, CHUNKSIZE - gStream.avail_out, 1, gOutFile) != 1)
>                        ^
> -----
> 
> Looking at the code it seems cppcheck is probably right?
> 

Seems so, and upstream had already fixed that issue [1] which I've
backported into attached archive.

Footnotes:
[1]  https://github.com/vasi/pixz/commit/2f4db115586bd3d98c1f05eb64c125495bf0331a

-- 
wbr, Kirill