Index | Thread | Search

From:
Russ Sharek <bsdclown@disroot.org>
Subject:
Re: [NEW] net/crawley-v1.7.5
To:
Jeremie Courreges-Anglas <jca@wxcvbn.org>
Cc:
Edd Barrett <edd@theunixzoo.co.uk>, ports@openbsd.org
Date:
Wed, 1 May 2024 01:07:07 -0400

Download raw body.

Thread
On Mon, Apr 29, 2024 at 01:45:03PM +0200, Jeremie Courreges-Anglas wrote:
> A few nits:
> - the port doesn't install any doc and DESCR is rather light.  I
>   understand the tool is simple but still, it would be nice to at least
>   have the examples from the README.  Maybe just install that file under
>   share/doc/crawley?
> - make test fails for bad reasons and I don't know how to fix that.
>   NO_TEST=Yes?

Thank you for the useful nits!

Here's a diff that adds both the NO_TEST and README.md to the port.

diff -ur projects/git.disroot.org/mystuff/net/crawley/Makefile /usr/ports/mystuff/net/crawley/Makefile
--- projects/git.disroot.org/mystuff/net/crawley/Makefile	Wed May  1 00:57:52 2024
+++ /usr/ports/mystuff/net/crawley/Makefile	Wed May  1 00:50:43 2024
@@ -14,9 +14,15 @@
 # MIT
 PERMIT_PACKAGE =	Yes
 
+NO_TEST =	Yes
+
 WANTLIB += c pthread
 
 MODULES =	lang/go
+
+post-install:
+	${INSTALL_DATA_DIR} ${PREFIX}/share/doc/crawley
+	${INSTALL_DATA} ${WRKSRC}/README.md ${PREFIX}/share/doc/crawley
 
 .include "modules.inc"
 
diff -ur projects/git.disroot.org/mystuff/net/crawley/pkg/PLIST /usr/ports/mystuff/net/crawley/pkg/PLIST
--- projects/git.disroot.org/mystuff/net/crawley/pkg/PLIST	Wed May  1 00:57:52 2024
+++ /usr/ports/mystuff/net/crawley/pkg/PLIST	Wed May  1 00:45:15 2024
@@ -1 +1,3 @@
 @bin bin/crawley
+share/doc/crawley/
+share/doc/crawley/README.md