Index | Thread | Search

From:
"Johannes Thyssen Tishman" <johannes@thyssentishman.com>
Subject:
Re: [update] editors/vis 0.8 -> 0.9
To:
"James Cook" <falsifian@falsifian.org>
Cc:
<ports@openbsd.org>, "Klemens Nanni" <kn@openbsd.org>
Date:
Tue, 07 May 2024 13:10:42 +0000

Download raw body.

Thread
2024-05-05T23:53:00Z "James Cook" <falsifian@falsifian.org>:
> A bit more info:
>
> I get the same result on my laptop. (The bug I mentioned in my
> previous email was a broken version of dwz; pkg_add -u dwz fixed
> it.)

Thanks for looking into this James, I think I've found the issue. If you
look at line 539 of the test.log file I sent, you'll see the following:

gmake[2]: Entering directory '/usr/ports/pobj/vis-0.9/vis-0.9/test/sam'
sam(1) not found, skipping tests

On yours:

gmake[2]: Entering directory '/home/pobj/vis-0.9/vis-0.9/test/sam'
/usr/local/plan9/bin/sam

So it seems that because you've installed the plan9/plan9port (I assume)
which includes a binary for sam, it runs the tests for sam. I don't have
it which makes it skip them. Running the tests with sam installed yields
the same test failures for me (Tests ok 22/26). I also tried using the
plan9/sam port instead and even less tests are passed (Tests ok 20/26).

The question here is: Should plan9/sam (not plan9/plan9port as it is
much larger) be added as a test dependency?

kn@ what's your opinion on this?