On 2024/05/22 03:53, Yozo TODA wrote:
> >
> >   - HOMEPAGE to github URL, because osdn.jp is now dead
> >   - update to ac20220213, including all the subsequent commits till today
> >     (PKGNAME is just lha-1.14i.ac20220213, without commit ID)

ac20220213 would be something like commit ee7fbac2c6a, normally if we
pick a later commit we'd include the date in the package name somehow.
But with the upstream version string as it is, the usual method would
end up with e.g. lha-1.14i.ac20220213pl20230913 which is quite messy.

What do you think of using lha-1.14i.ac20230913?

The diff can be tidied a bit (DISTNAME and HOMEPAGE are set by default
with DIST_TUPLE, no need for separate variables).

Index: Makefile
===================================================================
RCS file: /cvs/ports/archivers/lha/Makefile,v
diff -u -p -r1.41 Makefile
--- Makefile	11 Mar 2022 18:16:19 -0000	1.41
+++ Makefile	22 May 2024 10:07:12 -0000
@@ -1,24 +1,22 @@
 COMMENT=	archive files using LZW compression (.lzh files)
 
-VERSION=	1.14i-ac20210926
-DISTNAME=	lha-${VERSION}
-PKGNAME=	lha-${VERSION:C/-/./}
+DIST_TUPLE=	github jca02266 lha 4f193b1e98700aa2bc9dfeef11943efc1f036154 .
+PKGNAME=	lha-1.14i.ac20230913
 CATEGORIES=	archivers
 
-HOMEPAGE=       https://lha.osdn.jp/
-
 MAINTAINER=	Yozo Toda <yozo@v007.vaio.ne.jp>
 
 # Restrictive
 PERMIT_PACKAGE=	Yes
-WANTLIB=		c
 
-GH_ACCOUNT =	jca02266
-GH_PROJECT =	lha
-GH_TAGNAME =	release-20210926
+WANTLIB=		c iconv
 
 CONFIGURE_STYLE=	autoreconf
-AUTOCONF_VERSION =	2.71
-AUTOMAKE_VERSION =	1.16
+AUTOCONF_VERSION=	2.71
+AUTOMAKE_VERSION=	1.16
+CONFIGURE_ENV=		CPPFLAGS="-I${LOCALBASE}/include" \
+			LDFLAGS="-L${LOCALBASE}/lib"
+
+LIB_DEPENDS=		converters/libiconv
 
 .include <bsd.port.mk>
Index: distinfo
===================================================================
RCS file: /cvs/ports/archivers/lha/distinfo,v
diff -u -p -r1.7 distinfo
--- distinfo	4 Nov 2021 12:29:11 -0000	1.7
+++ distinfo	22 May 2024 10:07:12 -0000
@@ -1,2 +1,2 @@
-SHA256 (lha-1.14i-ac20210926.tar.gz) = t6WO6kRk3BGo0v+MYAKCoduAK7Vb5PjyP4/b/DOvUfs=
-SIZE (lha-1.14i-ac20210926.tar.gz) = 228249
+SHA256 (jca02266-lha-4f193b1e98700aa2bc9dfeef11943efc1f036154.tar.gz) = rCGysbzU6y/f1bmCLoaCX7htMRkJjy7SajZdKImvZLg=
+SIZE (jca02266-lha-4f193b1e98700aa2bc9dfeef11943efc1f036154.tar.gz) = 231170