Index | Thread | Search

From:
Stuart Henderson <stu@spacehopper.org>
Subject:
Re: [new] archivers/py-zstandard
To:
"Kirill A. Korinsky" <kirill@korins.ky>, OpenBSD ports <ports@openbsd.org>
Date:
Sun, 09 Jun 2024 23:03:50 +0100

Download raw body.

Thread
I'd expect cffi to use dlopen not static linking. We normally record those 
as LIB_DEPENDS and WANTLIB with a comment next to the WANTLIB saying "uses 
dlopen" (check-lib-depends will say 'Extra' in that case).

-- 
  Sent from a phone, apologies for poor formatting.

On 8 June 2024 00:04:57 Kirill A. Korinsky <kirill@korins.ky> wrote:

> ports@,
>
> Here the new port archivers/py-zstandard which is part of dependency tree of
> security/wapiti which I'm working to update and fix
>
> Unfortently I can't fix tests and make test fails as:
>
>  ImportError while importing test module 
>  '/usr/ports/pobj/py-zstandard-0.22.0-python3/zstandard-0.22.0/tests/test_open.py'.
>  Hint: make sure your test modules/packages have valid Python names.
>  Traceback:
>  /usr/local/lib/python3.11/importlib/__init__.py:126: in import_module
>      return _bootstrap._gcd_import(name[level:], package, level)
>  tests/test_open.py:6: in <module>
>      import zstandard as zstd
>  zstandard/__init__.py:39: in <module>
>      from .backend_c import *  # type: ignore
>  E   ModuleNotFoundError: No module named 'zstandard.backend_c'
>  _______________ ERROR collecting tests/test_train_dictionary.py 
>  ________________
>
> I have no idea how to fix it, but I've tested on -current/amd64 by hand and
> it works.
>
> Also, to avoid static linking against zstd I disabled CFFI part of that
> library, but so-called C-backend works well.
>
> --
> wbr, Kirill