On Wed, 12 Jun 2024 at 07:57:44 +0200, Rafael Sadowski wrote:
> On Tue Jun 11, 2024 at 08:19:27PM GMT, joshua stein wrote:
> > On Tue, 11 Jun 2024 at 21:41:42 +0200, Rafael Sadowski wrote:
> > > > diff --git lang/crystal/files/crystal lang/crystal/files/crystal
> > > > index 13b5c126329..9c748c92a64 100644
> > > > --- lang/crystal/files/crystal
> > > > +++ lang/crystal/files/crystal
> > > > @@ -2,4 +2,5 @@
> > > >  
> > > >  export CRYSTAL_PATH="lib:${TRUEPREFIX}/lib/crystal"
> > > >  export CRYSTAL_LIBRARY_PATH=lib:${TRUEPREFIX}/lib
> > > > +export LD_LIBRARY_PATH="${TRUEPREFIX}/llvm13/lib"
> > > 
> > > llvm13?
> > 
> > yeah yeah
> 
> Compiles and tests runs fine.
> 
> Missing: event_extra.1 from libevent-2.1.12p1 (/usr/local/bin/shards)
> WANTLIB += event_extra

Added.

> With this and the two comments below OK rsadowski.

Thanks.

> > + if [ -x "$CRYSTAL_DIR/crystal" ]; then
> > +   __warning_msg "Using compiled compiler at ${CRYSTAL_DIR#"$PWD/"}/crystal"
> > ++  export LD_LIBRARY_PATH=/usr/local/llvm17/lib
> > ++  export LLVM_CONFIG=/usr/local/llvm17/bin/llvm-config
> 
> Could we use ${MODCLANG_VERSION} here too?

The patches to the source also have to be applied to a tree that is 
cross-compiled on macOS to build the bootstrap crystal.o fetched as 
part of this port, so I'd prefer to keep the patches as-is not 
needing processing.  Though I can add a comment by the 
MODCLANG_VERSION definition to keep the patches updated when it gets 
bumped.