On Sat, Jun 15, 2024 at 09:43:16PM +0200, Stefan Sperling wrote:
> On Sat, Jun 15, 2024 at 12:42:02AM +0200, Solene Rapenne wrote:
> > this diff adds my Xbox One S Controller to sdl2
> > controller database so it works in chiaki (and maybe other)
> > 
> > ok?

Could you by any chance check if this same patch is also needed on
Linux? There now being multiple such cases makes me worry about a bug
in the GUID code.

And/or check what GUID you get on Linux, for example with sdl2-jstest
like what we have in ports (package sdl-jstest), and see if there is a
difference... Not observed with the (very limited) number of gamepads
that I did the development with, but at this point probably worth
checking.

> ok with me
> 
> Not sure what the situation is with upstreaming these SDL patches?
> It's a bit annoying that we have to add patches like this to make
> our controllers work, and it implies that there might be other
> non-working controllers out there that just never get added.
> Many people trying such controllers probably assume OpenBSD is broken.
> But I don't have time myself to discuss this problem with upstream.