On Sun, Jun 23, 2024 at 12:39:12PM +0100, Kirill A. Korinsky wrote:
> On Sun, 23 Jun 2024 11:53:31 +0100,
> Jeremie Courreges-Anglas <jca@wxcvbn.org> wrote:
> > 
> > > I guess it should be backported to stable as well.
> > > 
> > > Tested on -current/amd64 (and writing this email from an ipdate)
> > 
> > Did you actually test using the emacs-29.4 package installed on your
> > system?  Build fails here because upstream modified ack.texi after
> > regenerating emacs.info, and makeinfo from base can't regenerate
> > emacs.info.
> > 
> > I wonder how you managed to work around that.
> 
> I confirm that the first attempt to build the port fails, but I encounter
> fails releativly often due to double free inside lld [1], I assume that it
> was again lld

Ouch.  I suggest you send a follow-up to that mail, witha proper
Subject: (the initial one was empty) and that you add some data like,
do you change vm.malloc_conf, etc.

> and simple re-run build and it had compiled and installed and
> I write reply to you from
> 
>   GNU Emacs 29.4 (build 1, x86_64-unknown-openbsd, GTK+ Version 3.24.42, cairo version 1.18.0) of 2024-06-22
>
> but right now I've scrolled up the terminal which I've used to build it, and
> it indeed had failed on regenerating emacs.info as:
> 
>    gmake[2]: Entering directory '/usr/ports/pobj/emacs-29.4-gtk3/emacs-29.4/doc/emacs'
>    makeinfo --force --enable-encoding -I . --no-split -o ../../info/emacs.info emacs.texi
>    /usr/ports/pobj/emacs-29.4-gtk3/emacs-29.4/doc/emacs//docstyle.texi:3: warning: unrecognized encoding name `UTF-8'.
>    /usr/ports/pobj/emacs-29.4-gtk3/emacs-29.4/doc/emacs//custom.texi:809: Unknown command `quoteleft'.
>    /usr/ports/pobj/emacs-29.4-gtk3/emacs-29.4/doc/emacs//custom.texi:809: Misplaced {.
>    /usr/ports/pobj/emacs-29.4-gtk3/emacs-29.4/doc/emacs//custom.texi:809: Misplaced }.
>    /usr/ports/pobj/emacs-29.4-gtk3/emacs-29.4/doc/emacs//custom.texi:809: Unknown command `quoteright'.
>    /usr/ports/pobj/emacs-29.4-gtk3/emacs-29.4/doc/emacs//custom.texi:809: Misplaced {.
>    /usr/ports/pobj/emacs-29.4-gtk3/emacs-29.4/doc/emacs//custom.texi:809: Misplaced }.
>    /usr/ports/pobj/emacs-29.4-gtk3/emacs-29.4/doc/emacs//custom.texi:814: Unknown command `quoteleft'.
>    /usr/ports/pobj/emacs-29.4-gtk3/emacs-29.4/doc/emacs//custom.texi:814: Misplaced {.
>    /usr/ports/pobj/emacs-29.4-gtk3/emacs-29.4/doc/emacs//custom.texi:814: Misplaced }.
>    /usr/ports/pobj/emacs-29.4-gtk3/emacs-29.4/doc/emacs//custom.texi:814: Unknown command `quoteright'.
>    /usr/ports/pobj/emacs-29.4-gtk3/emacs-29.4/doc/emacs//custom.texi:814: Misplaced {.
>    /usr/ports/pobj/emacs-29.4-gtk3/emacs-29.4/doc/emacs//custom.texi:814: Misplaced }.
>    gmake[2]: *** [Makefile:170: ../../info/emacs.info] Error 1
>    gmake[2]: Leaving directory '/usr/ports/pobj/emacs-29.4-gtk3/emacs-29.4/doc/emacs'
>    gmake[1]: *** [Makefile:1122: emacs-info] Error 2
>    gmake[1]: Leaving directory '/usr/ports/pobj/emacs-29.4-gtk3/emacs-29.4'
>    gmake[1]: Entering directory '/usr/ports/pobj/emacs-29.4-gtk3/emacs-29.4'
>    ***
>    *** "make all" failed with exit status 2.
>    ***
>    *** You could try to:
>    *** - run "make bootstrap", which might fix the problem
>    *** - run "make V=1", which displays the full commands invoked by make,
>    ***   to further investigate the problem


That's also the error I got.  I'm not sure I understand correctly, but
I did not manage to get a single successful make build/package,
despite multiple attempts with or without MAKE_JOBS=n.  But hey,
sometimes using multiple make jobs can have unexpected effects...

> 
> But switching to print/texinfo helps to build it without error from the
> first attemp. I did it as:
> 
> diff --git editors/emacs/Makefile editors/emacs/Makefile
> index 6479718eb2d..a2c59e02745 100644
> --- editors/emacs/Makefile
> +++ editors/emacs/Makefile
> @@ -31,7 +31,8 @@ CONFIGURE_ARGS=		--build="${GCCARCH}" \
>  			--without-sound
>  
>  CONFIGURE_ENV=		CPPFLAGS="-I${LOCALBASE}/include" \
> -			LDFLAGS="-L${LOCALBASE}/lib ${LDFLAGS}"
> +			LDFLAGS="-L${LOCALBASE}/lib ${LDFLAGS}" \
> +			MAKEINFO="${LOCALBASE}/bin/gmakeinfo"
>  
>  MAKE_ENV=		INSTALL_EMACS="${INSTALL_SCRIPT}" \
>  			LOGNAME="${SHAREOWN}"
> @@ -39,6 +40,7 @@ MAKE_ENV=		INSTALL_EMACS="${INSTALL_SCRIPT}" \
>  SUBST_VARS=		GCCARCH VERSION
>  
>  USE_GMAKE=		Yes
> +BUILD_DEPENDS=		print/texinfo

Nah, I don't want to pull in texinfo/texlive for this glitch.  I can
just touch emacs.info in the port Makefile.

Thanks,

>  LIB_DEPENDS=		databases/sqlite3 \
>  			devel/jansson \
>  			devel/gmp \
> 
> 
> 
> Footnotes:
> [1]  https://marc.info/?l=openbsd-bugs&m=171758123323814&w=2
> 
> -- 
> wbr, Kirill
> 

-- 
jca