On Wed, Jun 26, 2024 at 05:43:16PM +0200, Jeremie Courreges-Anglas wrote:
> On Tue, Jun 25, 2024 at 05:38:02PM -0700, Bryan Vyhmeister wrote:
> > I have a project that requires rsync with zstd compression and I would
> > like to have the option in ports without having to manually modify my
> > rsync port Makefile if possible. The zstd option is disabled in the
> > rsync port right now. This diff would add a flavor for zstd. I'm not
> > sure everyone would want zstd enabled globally but a flavor might work
> > instead? Thoughts?
> 
> I haven't tested zstd with rsync to tell how useful it is.  However,
> the diff should be tightened.  The empty FLAVOR fails to build because
> zstd is required by default and you dropped the explicit
> --disable-zstd.

In my tests it still built fine without the explict --disable-zstd but I
may have missed it since I didn't try it on a completely clean tree. I
wasn't sure how to keep zstd disabled for the default build but add it
back in for a flavor.

> Also we should forcefully disable support for iconv or zstd if not
> present in FLAVOR, to avoid hidden dep issues in the resulting package
> and in bulk builds.
> 
> Also, pkg/DESCR should mention the zstd FLAVOR (not included).

Thanks for the feedback. I will fix these issues.

Bryan