On Wed, Jun 26, 2024 at 05:35:14PM +0100, Stuart Henderson wrote:
> On 2024/06/25 17:38, Bryan Vyhmeister wrote:
> > I have a project that requires rsync with zstd compression and I would
> > like to have the option in ports without having to manually modify my
> > rsync port Makefile if possible. The zstd option is disabled in the
> > rsync port right now. This diff would add a flavor for zstd. I'm not
> > sure everyone would want zstd enabled globally but a flavor might work
> > instead? Thoughts?
> 
> I'd prefer either a "minimal" flavour to satisfy those people who don't
> want rsync to run-depend on other things, or to leave the unflavoured
> version minimal and have "full" that turns on the various options.
> 
> Otherwise, adding zstd means we'll need to build two more (and test for
> updates),
> 
>       SUBDIR += rsync
>       SUBDIR += rsync,iconv
> +     SUBDIR += rsync,zstd
> +     SUBDIR += rsync,iconv,zstd
> 
> and if there are any other features that are wanted (there's also
> lz4, and who knows what might come later), then it gets silly.

I think your idea of a minimal flavor is the best and much better than
my flavor attempt. I will generate a new diff that enables iconv, lz4,
and zstd in the main build and then has a minimal flavor that does not
have any of those options. Thank you.

Bryan