Le Monday 15 Jul 2024 à 12:37:15 (GMT), Stuart Henderson a écrit :
> A few comments - I've attached an updated tgz addressing them.
> I can't test runtime myself, but that tweaked version would be ok
> with me to import.
> - The flavour name would be better as just "pcsc", however, for libraries
> it's usually a bad idea to use flavours. I would make a decision and
> either include pcsc-lite by default, or remove the flavour unless
> someone has a specific need for it.
> (As things are now, it's broken anyway, trying to use the flavour
> results in "configure: error: Unknow driver: pn53x_usbacr122_pcsc" due
> to a missing ,).

Oh ! Sorry about that.
I had started out with more flavors (with/without USB, with/without PC/SC,
etc.) and adjusted at the last minute.

> - SHARED_LIBS versions should start at 0.0.

ok

> - DESCR has a bit much "advertising style" blurb. Just talk about what
> the software does.

ok

> - The share/examples directory shouldn't include the version number,
> just name it share/examples/nfc. libnfc.conf.sample should be
> installed into /etc/nfc via the @sample mechanism.

I was under the impression that it was only for rc scripts.
Thanks for the clarification.

So shouldn't it be ${SYSCONFDIR}/nfc/ and not ${SYSCONFDIR}/libnfc/ in
PLIST? 

> - If NO_TEST is removed and you run "make test" there are no errors;
> in that situation we normally don't include NO_TEST, only if there
> are no tests and it errors out, or if tests are present but require
> extra dependencies. (Reasoning being that if tests are enabled in
> a later version we normally want them to run). Actually there are
> tests and we have the prerequisite dependency (cutter) but the
> autoconf scripts are not allowing this to be detected, probably
> due to a bug.

In fact, I didn't know there were tests for libnfc...

Thank you.

-- 
Denis