Index | Thread | Search

From:
Stuart Henderson <stu@spacehopper.org>
Subject:
Re: Enable VA-API in x11/qt6/qtmultimedia
To:
José Maldonado <josemald89@gmail.com>, Rafael Sadowski <rafael@sizeofvoid.org>, ports <ports@openbsd.org>
Date:
Tue, 30 Jul 2024 21:24:55 +0100

Download raw body.

Thread
Yes but it needs some note about dlopen so when someone finally gets round 
to doing a proper WANTLIB sync across the tree (which is long overdue) they 
won't see it listed as Extra and remove it :-)

-- 
  Sent from a phone, apologies for poor formatting.

On 29 July 2024 17:46:01 José Maldonado <josemald89@gmail.com> wrote:

> El lun, 29 jul 2024 a la(s) 12:21 p.m., Stuart Henderson
> (stu@spacehopper.org) escribió:
>>
>> On 2024/07/29 12:06, José Maldonado wrote:
>> > El lun, 29 jul 2024 a la(s) 1:55 a.m., Rafael Sadowski
>> > (rafael@sizeofvoid.org) escribió:
>> > >
>> > > On Sun Jul 28, 2024 at 07:51:14PM GMT, José Maldonado wrote:
>> > > > El dom, 28 jul 2024 a la(s) 4:09 p.m., Rafael Sadowski
>> > > > (rafael@sizeofvoid.org) escribió:
>> > > > >
>> > > > > On Sun Jul 28, 2024 at 09:59:49AM GMT, Rafael Sadowski wrote:
>> > > > > > OK to enable VA-API support in qt6multimedia?
>> > > > > >
>> > > > > > I've been using it for a few weeks and haven't noticed any 
>> problems so
>> > > > > > far.
>> > > > > >
>> > > > > > Index: Makefile
>> > > > > > ===================================================================
>> > > > > > RCS file: /cvs/ports/x11/qt6/qtmultimedia/Makefile,v
>> > > > > > diff -u -p -r1.13 Makefile
>> > > > > > --- Makefile  17 Jul 2024 07:30:57 -0000      1.13
>> > > > > > +++ Makefile  28 Jul 2024 07:58:12 -0000
>> > > > > > @@ -1,7 +1,7 @@
>> > > > > >  QT6NAME =    QtMultimedia
>> > > > > >  COMMENT =    Qt6 multimedia components
>> > > > > >  PKGSPEC =    qt6-qtmultimedia-${QT6_PKGSPEC}
>> > > > > > -REVISION =   0
>> > > > > > +REVISION =   1
>> > > > > >
>> > > > > >  SHARED_LIBS +=  Qt6Multimedia             6.0 # 6.6
>> > > > > >  SHARED_LIBS +=  Qt6MultimediaQuick        4.0 # 6.6
>> > > > > > @@ -16,7 +16,7 @@ WANTLIB += Xrandr avcodec avformat avuti
>> > > > > >  WANTLIB += gstallocators-1.0 gstapp-1.0 gstaudio-1.0 gstbase-1.0
>> > > > > >  WANTLIB += gstgl-1.0 gstpbutils-1.0 gstphotography-1.0 gstreamer-1.0
>> > > > > >  WANTLIB += gstvideo-1.0 gthread-2.0 intl m pulse swresample swscale
>> > > > > > -WANTLIB += xkbcommon
>> > > > > > +WANTLIB += va va-drm xkbcommon
>> > > >
>> > > > Why only active va and va-drm in WANTLIB?
>> > > >
>> > > > Usually, VAAPI activation require va va-drm and va-x11
>> > > >
>> > >
>> > > This is not my decision. This is generated on the basis of the 
>> libraries used
>> > > by qtmultimedia.
>>
>> If a port uses some version of a library via dlopen and we know about
>> it, we often list it like this
>>
>> # via dlopen
>> WANTLIB += foo
>>
>> often such ports use dlopen at runtime so that they'll work whether that
>> library is installed or not, but still need to be rebuilt if the ABI
>> changes, and without the "extra" WANTLIB pkg_add won't find the update.
>>
>
> Good to know, especially since I'm new in porting stuff. But it's
> understandable, after all, if the port doesn't find the library, and
> it needs it for some function, it will fail.
>
> The best thing (from my point of view) is to point the library and
> make sure it's there, if you use it, it won't fail and thus you avoid
> "weird bugs".
>
> Thanks for your explanation!
>
> --
> "Dios en su Cielo, todo bien en la Tierra"
> ***********************************************