Hi,

Just some comments.

Timo Myyrä <timo.myyra@bittivirhe.fi> writes:

> Hi,
>
> Here's a bit long overdue update for the ECL port.
> Lightly tested on amd64.
>
> timo
>
> diff /usr/ports
> commit - 91c62197c95d894e5fecbb4866735eb37d9ec02a
> path + /usr/ports
> blob - 5d1ff4982781db1ed5fc9dfa5c1fb5c2680b06af
> file + lang/ecl/Makefile
> --- lang/ecl/Makefile
> +++ lang/ecl/Makefile
> @@ -1,9 +1,9 @@
>  COMMENT =	embeddable common-lisp
>  CATEGORIES =	lang
>  
> -V =		21.2.1
> +V =		24.5.10
>  DISTNAME =	ecl-$V
> -SHARED_LIBS +=	ecl	8.0
> +SHARED_LIBS +=	ecl	9.0
>  
>  REVISION =	0

REVISION should be removed


And the regress doesn't work anymore: ecl use explicitly /bin/bash for
testing.

So I also have:

-TEST_DEPENDS = ${BASE_PKGPATH}
+TEST_DEPENDS = ${FULLPKGNAME}:${BUILD_PKGPATH} \
+               shells/bash

And a patch for src/tests/Makefile.in

blob - /dev/null
file + lang/ecl/patches/patch-src_tests_Makefile_in (mode 644)
--- /dev/null
+++ lang/ecl/patches/patch-src_tests_Makefile_in
@@ -0,0 +1,12 @@
+Index: src/tests/Makefile.in
+--- src/tests/Makefile.in.orig
++++ src/tests/Makefile.in
+@@ -2,7 +2,7 @@
+ # vim: set filetype=makefile tabstop=8 shiftwidth=4 expandtab:
+
+ ECL=@prefix@/@bindir@/ecl@EXEEXT@
+-SHELL=/bin/bash -o pipefail
++SHELL=bash -o pipefail
+
+ .PHONY: all check ansi-test
+


Thanks.
-- 
Sebastien Marie