On 2024/08/15 09:52, Omar Polo wrote:
> On 2024/08/15 00:57:31 +0100, Stuart Henderson <stu@spacehopper.org> wrote:
> > I'd use pretty much any other old uid than _nginx as that's one of the more 
> > common ports to install. Just looking at spare numbers showing in the diff, 
> > 594/596 are way less common so fewer people will need to mess about with 
> > rmuser.
> 
> _nginx is actually the oldest one, Feb 2012, followed by apache-http in
> Jul 2015.

yes, exactly - avoided reusing earlier because those were common and
the user interface for a uid conflict is a little clunky (you need to
install to see the error, uninstall, remove user/group, reinstall).

> But I get your point, I was a bit worried too.  I'll get 665
> then, used by audio/hgd and removed in august 2016.

fine with me.

comments inline:

: # GPLv2

"either version 2 of the License, or (at your option) any later
version." -> GPLv2+

: -	pidfile = "var/run/hopm.pid";
: +	pidfile = "/var/run/hopm/hopm.pid";
...
: -#	scanlog = "var/log/scan.log";
: +#	scanlog = "/var/log/hopm/scan.log";
...
: @sample ${LOCALSTATEDIR}/log/hopm/
: @sample ${LOCALSTATEDIR}/run/hopm/

if you use /var in the patch, use /var in the PLIST (and I think that
is better than LOCALSTATEDIR here)

/var/run is cleared at boot, this must be created in the rc script

otherwise ok