Index | Thread | Search

From:
Landry Breuil <landry@openbsd.org>
Subject:
Re: net/synapse: fix tests
To:
ports@openbsd.org
Date:
Wed, 21 Aug 2024 17:00:21 +0200

Download raw body.

Thread
Le Wed, Aug 21, 2024 at 03:49:45PM +0200, Kirill A. Korinsky a écrit :
> ports@,
> 
> Here a ping from another diff from my

can you explain the dance about dropping/copying tests in pre-test ?
why was that needed ? isn't doing MODPY_PYTEST_ARGS = --forked enough ?

> > On 6/10/24 4:01 PM, Kirill A. Korinsky wrote:
> > > ports@
> > > 
> > > I discovered that make test for net/synapse doesn't work, all tests fail.
> > > 
> > > Thus, tests seems to be leaked and it consumes near 8G of RAM before it was
> > > killed due to hit the hard limit on my system.
> > > 
> > > To avoid that I had added pytest-forked to run each test in dedicated
> > > process that allows to limit memory consumption to 200-300 mb.
> > > 
> > 
> > That's OK for me, but if you find a way so that it passes psql tests
> > too, like Landry@ suggested, that would be nice.
> >
> 
> diff --git net/synapse/Makefile net/synapse/Makefile
> index 5af1b855170..6554cad5b50 100644
> --- net/synapse/Makefile
> +++ net/synapse/Makefile
> @@ -72,11 +72,19 @@ RUN_DEPENDS +=	www/py-requests${MODPY_FLAVOR}
>  TEST_DEPENDS =	${FULLPKGNAME}:${BUILD_PKGPATH} \
>  		devel/py-mock${MODPY_FLAVOR} \
>  		devel/py-parameterized${MODPY_FLAVOR} \
> +		devel/py-test-forked${MODPY_FLAVOR} \
>  		www/py-jwt${MODPY_FLAVOR}
>  
>  do-configure:
>  	@${MODCARGO_configure}
>  
> +MODPY_PYTEST_ARGS =	--forked tests/
> +MODPY_TEST_DIR =	${WRKDIR}
> +
> +pre-test:
> +	@rm -fr ${WRKDIR}/tests
> +	@cp -r ${WRKSRC}/tests ${WRKDIR}/
> +
>  # to generate rust modules.inc:
>  #  make modcargo-gen-crates and modcargo-gen-crates-licenses
>  .include "modules.inc"
> 
> 
> -- 
> wbr, Kirill