Index | Thread | Search

From:
Sebastien Marie <semarie@kapouay.eu.org>
Subject:
Re: sysutils/sccache: ship docs, zap obsolete makefile stuff
To:
Klemens Nanni <kn@openbsd.org>, ports <ports@openbsd.org>, caspar@openbsd.org
Date:
Thu, 12 Sep 2024 17:05:00 +0200

Download raw body.

Thread
Klemens Nanni <kn@openbsd.org> writes:

> Usage is the only offline help you get and I don't like browsing github
> to find out how to use the tool.
>
> A few docs don't apply to us, but it's not worth filtering them, imho.
>
> While here, I noticed that it packages fine without the chmod hack;
> DISTFILES contains the tarball twice, so fix that as well.
>
> Feedback? OK?

it makes sense. ok semarie@ if it is fine for maintainer too.

>
> Index: Makefile
> ===================================================================
> RCS file: /cvs/ports/devel/sccache/Makefile,v
> diff -u -p -r1.11 Makefile
> --- Makefile	19 Jun 2024 15:16:36 -0000	1.11
> +++ Makefile	12 Sep 2024 14:54:25 -0000
> @@ -6,13 +6,12 @@ COMMENT =		compiler cache for C/C++/Rust
>  GH_ACCOUNT =		mozilla
>  GH_PROJECT =		sccache
>  GH_TAGNAME =		v0.8.1
> +REVISION =		0
>  
>  CATEGORIES =		devel
>  
>  MAINTAINER =		Caspar Schutijser <caspar@openbsd.org>
>  
> -FIX_EXTRACT_PERMISSIONS = Yes
> -
>  # Apache 2.0
>  PERMIT_PACKAGE =	Yes
>  
> @@ -27,8 +26,11 @@ CONFIGURE_STYLE =	cargo
>  LIB_DEPENDS +=		archivers/zstd
>  MODCARGO_RUSTFLAGS +=	-L${LOCALBASE}/lib
>  
> -# as devel/cargo MODULES adds DISTFILES, GH_* didn't
> -DISTFILES +=		${DISTNAME}${EXTRACT_SUFX}
> +DOCDIR =		${PREFIX}/share/doc/sccache
> +
> +post-install:
> +	${INSTALL_DATA_DIR} ${DOCDIR}
> +	${INSTALL_DATA} ${WRKSRC}/docs/*.md ${DOCDIR}/
>  
>  .include "crates.inc"
>  
> Index: pkg/PLIST
> ===================================================================
> RCS file: /cvs/ports/devel/sccache/pkg/PLIST,v
> diff -u -p -r1.1.1.1 PLIST
> --- pkg/PLIST	8 Nov 2023 18:20:53 -0000	1.1.1.1
> +++ pkg/PLIST	12 Sep 2024 14:23:50 -0000
> @@ -1 +1,21 @@
>  @bin bin/sccache
> +share/doc/sccache/
> +share/doc/sccache/Architecture.md
> +share/doc/sccache/Azure.md
> +share/doc/sccache/Caching.md
> +share/doc/sccache/Configuration.md
> +share/doc/sccache/Distributed.md
> +share/doc/sccache/DistributedFreeBSD.md
> +share/doc/sccache/DistributedQuickstart.md
> +share/doc/sccache/GHA.md
> +share/doc/sccache/Gcs.md
> +share/doc/sccache/Jenkins.md
> +share/doc/sccache/Local.md
> +share/doc/sccache/Memcached.md
> +share/doc/sccache/OSS.md
> +share/doc/sccache/Redis.md
> +share/doc/sccache/Releasing.md
> +share/doc/sccache/ResponseFiles.md
> +share/doc/sccache/Rust.md
> +share/doc/sccache/S3.md
> +share/doc/sccache/Webdav.md
>

-- 
Sebastien Marie