Index | Thread | Search

From:
Klemens Nanni <kn@openbsd.org>
Subject:
Re: [maintainer] sysutils/docker-buildx: update to 0.17.1
To:
"Kirill A. Korinsky" <kirill@korins.ky>, OpenBSD ports <ports@openbsd.org>
Date:
Thu, 3 Oct 2024 20:00:32 +0000

Download raw body.

Thread
30.09.2024 11:26, Kirill A. Korinsky пишет:
> ports@
> 
> Here an update of sysutils/docker-buildx to 0.17.1 and rework of port to use
> modules.inc instead of huge vendored artifact.

Are there problems with the single tarball or do contents differ?
Seems simpler port-wise to deal with a single file and not have any of that
modules.inc churn on updates.

> 
> Tested on amd64.
> 
> The diff:
> 
> Index: Makefile
> ===================================================================
> RCS file: /cvs/ports/sysutils/docker-buildx/Makefile,v
> retrieving revision 1.5
> diff -u -p -r1.5 Makefile
> --- Makefile	2 Sep 2024 05:13:52 -0000	1.5
> +++ Makefile	30 Sep 2024 08:24:33 -0000
> @@ -1,10 +1,8 @@
>  COMMENT =		Docker CLI plugin for extended build capabilities
>  
> -V =			0.16.2
> -GH_ACCOUNT =		docker
> -GH_PROJECT =		buildx
> -GH_TAGNAME =		v${V}
> -PKGNAME =		docker-${DISTNAME}
> +MODGO_MODNAME =		github.com/docker/buildx
> +MODGO_VERSION =		v0.17.1
> +DISTNAME =		docker-buildx-${MODGO_VERSION}

DISTNAME must not contain MODGO_VERSION's "v" prefix.

>  
>  CATEGORIES =		sysutils
>  
> @@ -18,16 +16,15 @@ PERMIT_PACKAGE =	Yes
>  WANTLIB += 		c pthread
>  
>  MODULES =		lang/go
> -GO_PKGNAME =		github.com/docker/buildx
> -MODGO_GOPATH =		${MODGO_WORKSPACE}
> -MODGO_LDFLAGS =		-X ${GO_PKGNAME}/version.Version=v${V}
> -
> -WRKSRC =		${MODGO_WORKSPACE}/src/${GO_PKGNAME}
> -ALL_TARGET =		${GO_PKGNAME}/cmd/buildx
> +MODGO_FLAGS =		-mod=readonly

What does this do and why is it needed?  Grepping the tree shows no
other ports doing that.

> +MODGO_LDFLAGS =		-X ${MODGO_MODNAME}/version.Version=${MODGO_VERSION}
>  
>  do-install:
>  	${INSTALL_PROGRAM_DIR} ${PREFIX}/libexec/docker/cli-plugins
>  	${INSTALL_PROGRAM} ${MODGO_WORKSPACE}/bin/buildx \
>  		${PREFIX}/libexec/docker/cli-plugins/docker-buildx
>  
> +NO_TEST = 		Yes
> +
> +.include "modules.inc"
>  .include <bsd.port.mk>