Index | Thread | Search

From:
Kirill A. Korinsky <kirill@korins.ky>
Subject:
Re: [maintainer] sysutils/docker-compose: update to 2.29.7
To:
Klemens Nanni <kn@openbsd.org>
Cc:
OpenBSD ports <ports@openbsd.org>
Date:
Thu, 03 Oct 2024 23:42:33 +0200

Download raw body.

Thread
On Thu, 03 Oct 2024 22:20:21 +0200,
Klemens Nanni <kn@openbsd.org> wrote:
> 
> > @@ -24,6 +24,8 @@ do-install:
> >  	${INSTALL_PROGRAM_DIR} ${PREFIX}/libexec/docker/cli-plugins
> >  	${INSTALL_PROGRAM} ${MODGO_WORKSPACE}/bin/cmd \
> >  		${PREFIX}/libexec/docker/cli-plugins/docker-compose
> > +
> > +NO_TEST = 		Yes
> 
> The port has tests, so this is not correct.
> 
> If they fail, they fail (and porters can do partial runs or try to fix them).
> If they require special setup, you can describe that in TEST_IS_INTERACTIVE.

Indeed, the error message had misslead me:

    no required module provides package github.com/docker/compose/v2; to add it:
            go get github.com/docker/compose/v2

The right fix for test is:

Index: Makefile
===================================================================
RCS file: /cvs/ports/sysutils/docker-compose/Makefile,v
retrieving revision 1.7
diff -u -p -r1.7 Makefile
--- Makefile	3 Oct 2024 20:18:36 -0000	1.7
+++ Makefile	3 Oct 2024 21:40:44 -0000
@@ -25,5 +25,8 @@ do-install:
 	${INSTALL_PROGRAM} ${MODGO_WORKSPACE}/bin/cmd \
 		${PREFIX}/libexec/docker/cli-plugins/docker-compose
 
+do-test:
+	cd ${WRKSRC} && ${MODGO_TEST_CMD} ./...
+
 .include "modules.inc"
 .include <bsd.port.mk>


-- 
wbr, Kirill