On Sun, Oct 06, 2024 at 03:07:19PM +0200, Caspar Schutijser wrote:
> Hi,
> 
> On Sat, Oct 05, 2024 at 01:16:25AM +0000, Lucas Raab wrote:
> > Hello,
> > 
> > Here's an update for sqlitebrowser that's worked fine with light testing
> > via the sqlports database. Other tests or comments on the patch?
> > 
> > changelog: https://github.com/sqlitebrowser/sqlitebrowser/releases/tag/v3.13.0
> 
> I tested it and looked at the diff, looks good to me. OK caspar@
> 
> Regarding the patch, I have one comment below.
> 
> > blob - /dev/null
> > blob + 7cbfcc523fae623bdd7f45eea0b20f209541a289 (mode 644)
> > --- /dev/null
> > +++ databases/sqlitebrowser/patches/patch-CMakeLists_txt
> > @@ -0,0 +1,14 @@
> > +Index: CMakeLists.txt
> > +--- CMakeLists.txt.orig
> > ++++ CMakeLists.txt
> > +@@ -517,10 +517,6 @@ if((NOT WIN32 AND NOT APPLE) OR MINGW)
> > +     )
> > + endif()
> > + 
> > +-if(UNIX)
> > +-    target_link_libraries(${PROJECT_NAME} dl)
> > +-endif()
> > +-
> 
> I was wondering if the "if(UNIX)" can become something like
> "if(UNIX AND NOT OPENBSD)" and that the patch can then be upstreamed,
> but I don't think it is a big deal.
> 

Doesn't hurt to pursue that. I can commit this and then if upstream
accepts it, remove it later (p0 or newer version, whichever happens).
thanks!

> > + if(ENABLE_TESTING)
> > +     add_subdirectory(src/tests)
> > + endif()
>