On Mon, Oct 28, 2024 at 11:27:21AM -0600, Theo de Raadt wrote:
> Hans-Jörg Höxer <hshoexer@genua.de> wrote:
> 
> > RAMDISK_CD has ccp(4) configured, but not psp(4).  Thus we either add
> > "ccp" to the patterns or we also add psp(4) to RAMDISK_CD?
> 
> You don't need the driver.  The purpose of the pattern match is only
> to pull the (unused) firmware ready for proper kernels.  fw_update runs
> twice, but something could go wrong either time.  That's why we want the
> pattern to do the best job of pulling the firmware.

ok, then I'd say we go with the patterns below.

-------------------------------------------------------------------------
commit b7ab0eee5240563a6abf393ae9bff4afb16a687d
Author: Hans-Joerg Hoexer <hshoexer@genua.de>
Date:   Mon Oct 28 13:07:50 2024 +0100

    fw_update: add pattern for AMD SEV firmware used with psp(4)

diff --git a/usr.sbin/fw_update/patterns.c b/usr.sbin/fw_update/patterns.c
index 868a2308b15..4a295c58daf 100644
--- a/usr.sbin/fw_update/patterns.c
+++ b/usr.sbin/fw_update/patterns.c
@@ -94,6 +94,10 @@ main(void)
 	print_devices("amdgpu", amdgpu_devices, nitems(amdgpu_devices));
 	printf("%s\n", "amdgpu ^vga*vendor \"ATI\", unknown product"); 
 	printf("%s\n", "amdgpu ^vendor \"ATI\", unknown product*class display");
+	printf("%s\n", "amdsev ^\"AMD*Crypto\"");
+	printf("%s\n", "amdsev ^\"AMD*PSP\"");
+	printf("%s\n", "amdsev ccp");
+	printf("%s\n", "amdsev psp");
 	printf("%s\n", "apple-boot ^cpu0*Apple");
 	printf("%s\n", "arm64-qcom-dtb ^qcgpio0");
 	printf("%s\n", "athn");

• smime.p7s (5K)