Stuart Henderson wrote:

> pkg-readme has some issues,
> 
> - (minor) ==== underlines don't match up with the lines above

Solved

> - I worry that people won't read the wall of text and just try
> to paste the chgrp/chmod directly. Better show something of a
> worked example of how to find the device nodes. I don't have a
> nitrokey but this is how it could be done for yubikey so this
> could be adapted.

Solved

> I think there were some other concerns voiced about
> 
> "Beware this may allow the user unintended access to other hardware
> associated to the same usb(4) controller, so do this with extreme
> caution."
> 
> ... what is the user supposed to do?

Removed

> - modules.inc is for ports with go modules. this should use crates.inc.

Solved

> - what's up with this MY_REPLACE_CMD, MY_HEADER stuff? just put the
> command in post-patch.
> 

Feel free to propose a way to include the whole command without making 
the line extremely large.

• nitrocli.tar.gz (6K)