On Wed, Nov 06, 2024 at 10:41:40AM +0100, Kirill A. Korinsky wrote:
> On Wed, 06 Nov 2024 10:20:53 +0100,
> Matthieu Herrb <matthieu@openbsd.org> wrote:
> >
> > I really don't like the UI, but that's not your fault.  (And the app
> > could display some informative error message rather than a python
> > backtrace on URLs that don't match the expected pattern).
> >
> 
> Yeah, it defently a good example of poor code.
> 
> > Last nit, maybe include the above explanations in pkg/DESCR ?
> >
> 
> Indeed, that makes sense. What do you think of this pkg/DESCR?
> 
>     Search, explore and download Lossless and Hi-Res music from Qobuz.
> 
>     It supports downloading music only from links that look like
>     https://play.qobuz.com/album/XXX where XXX is the album ID.
> 
>     You can find links to purchased albums on this page
>     https://play.qobuz.com/user/library/purchases/albums
> 
>     If you try to download an unpurchased album without a streaming
>     subscription, this tool will skip it as a demo track.
> 

That looks fine yes.
-- 
Matthieu Herrb