Index | Thread | Search

From:
Marc Espie <marc.espie.openbsd@gmail.com>
Subject:
Re: databases/ports-readmes, deduplicate categories
To:
Mikolaj Kucharski <mikolaj@kucharski.name>
Cc:
ports@openbsd.org
Date:
Wed, 6 Nov 2024 19:15:31 +0100

Download raw body.

Thread
On Wed, Nov 06, 2024 at 08:24:35AM +0000, Mikolaj Kucharski wrote:
> Hi,
> 
> While browsing generated HTML pages, I've noticed that some ports have
> categories duplicated. Initially I saw this with devel/apktool. With
> below diff, categories are unique.
> 
> 
> Index: Makefile
> ===================================================================
> RCS file: /cvs/ports/databases/ports-readmes/Makefile,v
> retrieving revision 1.12
> diff -u -p -u -r1.12 Makefile
> --- Makefile	11 Mar 2022 18:31:37 -0000	1.12
> +++ Makefile	6 Nov 2024 08:20:16 -0000
> @@ -1,7 +1,7 @@
>  COMMENT =		readmes.html
>  
>  PKG_ARCH = *
> -DISTNAME =		ports-readmes-3.1
> +DISTNAME =		ports-readmes-3.2
>  DISTFILES =
>  
>  CATEGORIES =		databases
> Index: files/make-readmes
> ===================================================================
> RCS file: /cvs/ports/databases/ports-readmes/files/make-readmes,v
> retrieving revision 1.9
> diff -u -p -u -r1.9 make-readmes
> --- files/make-readmes	11 Mar 2022 18:31:37 -0000	1.9
> +++ files/make-readmes	6 Nov 2024 08:20:16 -0000
> @@ -108,7 +108,7 @@ $not_for->bind_columns(\($arch));
>  
>  my $category;
>  my $cat_req = $db->prepare(
> -	q{select
> +	q{select distinct
>  		_categorykeys.value
>  	    from _categories
>  	    	join _categorykeys on _categorykeys.keyref=_categories.value
> 
> -- 
> Regards,
>  Mikolaj
> 
> 
looks good to me.

I would usually recommend using ports-readmes-dancer instead, but whatever