Index | Thread | Search

From:
Mikolaj Kucharski <mikolaj@kucharski.name>
Subject:
Re: lang/node v22.11.0
To:
Volker Schlecht <openbsd-ports@schlecht.dev>
Cc:
ports@openbsd.org, jca@openbsd.org
Date:
Thu, 7 Nov 2024 20:26:06 +0000

Download raw body.

Thread
On Thu, Nov 07, 2024 at 08:13:03PM +0000, Mikolaj Kucharski wrote:
> On Thu, Nov 07, 2024 at 08:14:26PM +0100, Volker Schlecht wrote:
> > Too early to ask for oks, but here's a diff to update lang/node to the new LTS
> > version. node's v8 has now almost caught up with the one from chromium, so
> > quite a few patches aren't needed anymore.
> > 
> > I've also tried to handle the OpenSSL version such that we won't have to update
> > the Makefile all over the place when switching versions, but I'm not yet sure
> > if the way I did it is particularly nice, so feedback and opinions are very welcome.
> > 
> > jca@, I *think* I got the riscv64 stuff right, but a test build would be great :-D
> 
> Giving it a build with debug package enabled via
> 
> https://marc.info/?l=openbsd-ports&m=173100797601439&w=2
> 

FYI, it failed here with:

...
In file included from ../src/js_native_api_v8.cc:7:
In file included from ../src/js_native_api_v8.h:5:
../src/js_native_api_v8_internals.h:19:10: fatal error: 'gtest/gtest_prod.h' file not found
#include "gtest/gtest_prod.h"
         ^~~~~~~~~~~~~~~~~~~~
1 error generated.
gmake[1]: *** [libnode.target.mk:407:
/usr/local/obj-ports/node-22.11.0/node-v22.11.0/out/Release/obj.target/libnode/src/js_native_api_v8.o] Error 1
gmake[1]: *** Waiting for unfinished jobs....
...

-- 
Regards,
 Mikolaj