Le Sun, Nov 03, 2024 at 12:58:01PM +0000, Stuart Henderson a écrit :
> On 2024/11/03 10:33, Rafael Sadowski wrote:
> > On Sun Nov 03, 2024 at 10:28:06AM +0100, Marc Espie wrote:
> > > pkg_mklocatedb includes an option -K that will store all pkg_create
> > > annotations such as fontdir, etc
> > > 
> > > even though it makes for a much larger pkglocatedb, it can occasionally be
> > > useful for introspection purposes (like finding out if some directories
> > > contain several types of info, like info files + man pages... should be
> > > rather unlikely, I know...)
> > > 
> > > Could we build this by default ? shouldn't take too much extra time.
> > 
> > Storage is cheap this days, so I opt to enabled it by default without a
> > flavor.
> 
> Separate please.
> 
> CPU (try running "make plist" following an update of ports with a large
> PLIST - many of the web applications, icon themes, and even things like
> yt-dlp) is not cheap.
> 
> Neither is bandwidth in some cases (remember this is always-update).
> 
> I'm ok with adding the flavour.

I had a second look, and actually i'd be ok with enabling it by default.
Adding it as a flavor makes it being built once more, and it takes ...
quite some time (1h30 on my builder, which isn't cheap)

the resulting db isn't that larger:

[17:28] c64:~/ $locate -S -d pkglocatedb-with-keywords
Filenames: 3856613, Characters: 455300409, Database size: 44484224
[17:29] c64:~/ $locate -S -d /usr/local/share/pkglocatedb
Filenames: 3856592, Characters: 454573893, Database size: 44133124

and having it by default allows porters (who imo are the main target for
such tool, eg looking what pkgpath provides which header/lib..) to
easily access this info (try pkglocate @shell or locate -d
pkglocatedb-with-keywords @lib |grep Qt6WebSock'...

it doesnt make the pkglocate output much more complicated, as @keywords
are just annotations with a meaning. I don't think they would confuse
'regular users' that much (and the default pkglocatedb already includes
some keywords anyway)

Landry