Index | Thread | Search

From:
Stuart Henderson <stu@spacehopper.org>
Subject:
Re: x11/qt6/qtbase: add run depends on graphics/vulkan-loader
To:
Rafael Sadowski <rafael@sizeofvoid.org>
Cc:
ports <ports@openbsd.org>
Date:
Mon, 11 Nov 2024 17:05:36 +0000

Download raw body.

Thread
On 2024/11/11 07:01, Rafael Sadowski wrote:
> I would like to add graphics/vulkan-loader as a run-dependency for
> qt6-qtbase.
> 
> I get more and more messages that vulkan is missing:
> 
> -- Could NOT find Vulkan (missing: Vulkan_LIBRARY Vulkan_INCLUDE_DIR) (found version "")
> -- Could NOT find WrapVulkanHeaders (missing: Vulkan_INCLUDE_DIR)

Could do, but I wonder, would it perhaps make more sense to add it
to MODQT6_BUILD_DEPENDS instead?

> This is often caused by /usr/local/lib/cmake/Qt6Gui (qtbase) or other Qt
> libs. Almost all of them have graphics/vulkan-loader as build depends
> but not as run.
> 
> Ok to fix this?
> 
> 
> diff --git a/x11/qt6/qtbase/Makefile b/x11/qt6/qtbase/Makefile
> index f04e1747d0b..063fddebab5 100644
> --- a/x11/qt6/qtbase/Makefile
> +++ b/x11/qt6/qtbase/Makefile
> @@ -4,6 +4,7 @@ COMMENT-main =		C++ general-purpose toolkit
>  COMMENT-global =	global Qt6 documentation internals
>  COMMENT-mysql =		MySQL plugin for Qt6
>  COMMENT-psql =		PostgresSQL plugin for Qt6
> +REVISION-main =		0
>  
>  PKGSPEC-main =		qt6-qtbase-${QT6_PKGSPEC}
>  
> @@ -32,7 +33,7 @@ SHARED_LIBS +=  Qt6OpenGLExtensions          0.1 # 6.7
>  SHARED_LIBS +=  Qt6XcbQpa                    4.0 # 6.7
>  SHARED_LIBS +=  Qt6EglFsKmsGbmSupport        0.2 # 6.7
>  SHARED_LIBS +=  Qt6OpenGLWidgets             1.0 # 6.7
> -WANTLIB += ${COMPILER_LIBCXX}
> +
>  WANTLIB-global =
>  
>  WANTLIB-main += ${COMPILER_LIBCXX} EGL GL ICE SM X11 X11-xcb atk-1.0
> @@ -98,6 +99,7 @@ BUILD_DEPENDS =		graphics/vulkan-loader \
>  			x11/gnome/at-spi2-core
>  
>  RUN_DEPENDS-main =	${RUN_DEPENDS} \
> +			graphics/vulkan-loader \
>  			x11/gnome/at-spi2-core
>  
>  RUN_DEPENDS-global =
>