Index | Thread | Search

From:
Lucas de Sena <lucas@seninha.org>
Subject:
Re: [NEW] net/tdlib-purple
To:
Klemens Nanni <kn@openbsd.org>, ports <ports@openbsd.org>
Cc:
Omar Polo <op@omarpolo.com>
Date:
Mon, 11 Nov 2024 17:25:56 -0300

Download raw body.

Thread
On 2024-11-09, Klemens Nanni wrote:
> The Makefile layout should follow that of Makefile.template

Other than tabbing (I aligned all values with three tabspaces from left
margin, while template sometimes uses two tabspaces for short variable
names), i think my makefile follows pretty much the template, including
the order of variables and blank lines between them.

On 2024-11-09, Klemens Nanni wrote:
> and you could also describe why a specific commit is used (no upstream
> tags/releases, certain fixes)

Done.  Updated tarball attached.

On 2024-11-09, Klemens Nanni wrote:
> COMPILER could use a comment like '# C++14'.

Done.  Updated tarball attached.

On 2024-11-09, Klemens Nanni wrote:
> Build fails for me:

That's because it depends on a version of net/tdlib newer than the one
in ports.  I have sent (and pinged) into this mailing list a patch for
such updated port.

I have changed this makefile to include a minimum version requirement
on that library dependency.  Updated tarball attached.

I added Omar Polo into Cc: for he maintains net/tdlib.