16.11.2024 22:44, Kirill A. Korinsky пишет:
> Thanks for review, addressed all changes with exception of
> deploy/synology_dsm.sh which uses /bin/bash: this script works only on
> Synology devices and I doubt that it's possible to make it work outside it.
> Thus, I think that nuke this script is bad idea because as soon as we do it,
> we should check all almost 200 scripts.

Agreed.

> Instead I'd like to import it as is, and wait reports.

OK kn

I Looked and failed to understand how changing a function's name from
login to _login fixes parsing the file or how switching from '"' to \"
does.

I tried a bit reproducing the vague errors, but failed.

Unless upstream ships files that break in other shells without noone
noticing, these might be bugs in our sh(1).

Can you please add comments to patches/patch-* describing what's going on?