Index | Thread | Search

From:
Brad Smith <brad@comstyle.com>
Subject:
Re: BUG: we should add devel/llvm/17 to RUN_DEPENDS on lang/crystal
To:
ports@openbsd.org, jcs@jcs.org
Date:
Sat, 23 Nov 2024 22:41:54 -0500

Download raw body.

Thread
On 2024-11-23 10:15 p.m., joshua stein wrote:
> On Sat, 23 Nov 2024 at 20:27:18 -0600, izzy Meyer wrote:
>> Hello ports@
>>
>> Crystal is a compiled language, and needs to link against llvm--%17 as
>> it currently stands. Most users who want to use this language will need
>> to compile.
>>
>> If devel/llvm/17 isn't installed, it fails with:
>> Dependencies are satisfied
>> Building: whatever
>> Error target whatever failed to compile:
>> ld.so: crystal: can't load library 'libLLVM-17.so'
>>
>> Could we add llvm--%17 to the RUN_DEPENDS?
> It used to be there before someone switched it to use the clang
> module, but this should add it back:
>
>
> diff --git lang/crystal/Makefile lang/crystal/Makefile
> index 6d978c85add..81b166e535e 100644
> --- lang/crystal/Makefile
> +++ lang/crystal/Makefile
> @@ -44,6 +44,7 @@ DISTFILES.c =	crystal-molinillo-${V}{v${V_MOLINILLO}}.tar.gz
>   # environment.
>   MODULES =	lang/clang
>   MODCLANG_VERSION = 17
> +MODCLANG_RUNDEP= yes
>   COMPILER =	ports-clang
>   LLVM_CONFIG =	llvm-config-${MODCLANG_VERSION}
>   

It should be a LIB_DEPENDS + WANTLIB.