On Sun, Nov 24, 2024 at 03:24:30PM +0100, Timothy M. Redaelli wrote:
> On Fri, 15 Nov 2024 13:27:11 +0100
> "Timothy M. Redaelli" <timothy@fsfe.org> wrote:
> 
> > Hi,
> > 
> > Electrs is an Electrum Server in Rust.
> > 
> > The motivation behind this project is to enable a user to self host an
> > Electrum server, with required hardware resources not much beyond those
> > of a Bitcoin full node (net/bitcoin).
> > The server indexes the entire Bitcoin blockchain, and the resulting
> > index enables fast queries for any given user wallet, allowing the user
> > to keep real-time track of balances and transaction history using the
> > Electrum wallet.
> > Since it runs on the user's own machine, there is no
> > need for the wallet to communicate with external Electrum servers, thus
> > preserving the privacy of the user's addresses and balances.
> 
> Hi,
> 
> I know it's my first port on OpenBSD, but I'm expert in packaging
> stuff (I maintain some packaging on RHEL and Fedora and I was a Gentoo
> Developer, Archlinux Trusted User, FreeSBIE developer, etc) so, if I
> did something wrong just tell me and I'll fix that.
> 
> Thank you

People haven't had enough time / interest to review it yet.

Port looks mostly fine, but I'm not an expert in Rust ports. I won't be
able to test the runtime for the next 2-3 weeks.


: COMMENT =		An efficient re-implementation of Electrum Server in Rust

Drop the "An ", and we don't capitalize the first word of COMMENT,
except for proper names.

: # electrs uses rocksdb, which is 64-bit only
: ONLY_FOR_ARCHS =	${LP64_ARCHS}
: 
: GH_ACCOUNT =		romanz
: GH_PROJECT =		electrs
: GH_TAGNAME =		v0.10.7
: 
: CATEGORIES =		net
: 
: HOMEPAGE =		https://github.com/romanz/electrs
: 
: MAINTAINER =		Timothy M. Redaelli <timothy@fsfe.org>
: 
: # MIT
: PERMIT_PACKAGE =	Yes
: 
: MODULES =		devel/cargo lang/clang
: MODCARGO_RUSTFLAGS =	-L${PREFIX}/lib

Why are you using PREFIX instead of LOCALBASE here?

: CONFIGURE_STYLE =	cargo
: 
: SEPARATE_BUILD =	Yes
: 
: .include "crates.inc"

Uncommon positioning, but I guess you lifted this from mail/stalwart.
Nevertheless, we tend to add it just before ".include <bsd.port.mk>".

: # for rocksdb bindings
: MODCARGO_ENV=		LIBCLANG_PATH=${LOCALBASE}/llvm${MODCLANG_VERSION}/lib
: MAKE_ENV +=		DEP_ZSTD_INCLUDE=${LOCALBASE}/include
: 
: # librocksdb-sys looks for libclang.so
: BUILD_DEPENDS=		devel/llvm/16
: LIB_DEPENDS +=		archivers/zstd
: 
: WANTLIB +=		${COMPILER_LIBCXX} c m zstd
: 
: do-install:
: 	${INSTALL_PROGRAM} ${MODCARGO_TARGET_DIR}/release/electrs ${PREFIX}/bin/
: 
: .include <bsd.port.mk>