Hi,

I'm planning to look into this more deeply at some point but I'm
quite busy at the moment so I don't know when I can look at your
submissions more thoroughly.

But here is a couple of points. I only had a quick look at the meek
port for now.

- Is there a reason you're picking
MODGO_VERSION = v0.38.1-0.20240318074918-169616fbbfbd and
PKGNAME =	meek-20240318
and not just v0.38.0? I see a v0.38.0 tag in the git history so
presumably it should be possible to use that version.

- You created a post-install target to install a manual page and a
readme file but they don't show up in the PLIST. Run
"make update-plist" to fix that.

- Technically the COMMENT is true but it's the same as the one for
snowflake_proxy. I'm not sure if that's considered a problem (opinions
welcome). If we really want to we can perhaps make it more specific to
this pluggable transport, e.g. "HTTP-based anti-censorship ...."

I may have more comments later.

Caspar

On Sun, Nov 24, 2024 at 06:19:58AM +0000, Stepan Zolotuev wrote:
> > Hi ports@,
> >
> > These two ports I hacked together in a couple of days, build and test
> > fine on -current/amd64.
> >
> > Any issues? OK?
> 
> 
> Updated, ports reattached.
> I also took maintainership of them all.
> 
> -- 
> for private communication:
> <https://kefir.tilde.institute/files/pgp.asc>